[kde-edu]: Re: Review Request: Removing code duplication in ObservingList.cpp

[Victor Carbune]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5969/#review8970
-----------------------------------------------------------


Thanks. Some minor other comments.


trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp
<http://svn.reviewboard.kde.org/r/5969/#comment9711>

    remove comment



trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp
<http://svn.reviewboard.kde.org/r/5969/#comment9712>

    initialize these 3 above, where you declare them



trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp
<http://svn.reviewboard.kde.org/r/5969/#comment9713>

    whitespace


- Victor


On 2010-11-25 01:00:36, Cezar Mocan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5969/
> -----------------------------------------------------------
> 
> (Updated 2010-11-25 01:00:36)
> 
> 
> Review request for KDE-Edu and Victor Carbune.
> 
> 
> Summary
> -------
> 
> Modified ObservingList.cpp and ObservingList.h. Removed code duplication.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.h 1200379 
>   trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp 1200379 
> 
> Diff: http://svn.reviewboard.kde.org/r/5969/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cezar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20101125/c6513a1d/attachment-0001.htm