[kde-edu]: Review Request: [Cantor] Improved Script editor window

[Miha Cancula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3878/
-----------------------------------------------------------

(Updated 2010-05-07 13:00:53.958733)


Review request for KDE-Edu and Alexander Rieder.


Changes
-------

I was busy with school this week, but I'm free today, and now I think this one is finished:

- fixed includes to be consistent.
- the caption is updated correctly (when saving, opening or closing).
- temporary files now work, the setPrefix("cantor/") was preventing their creation. 
- I couldn't test it yet, but a tempfile should also be created if we're working on a remote file (hence the url.isLocalFile check).
- window geometry of the ScriptEditorWidget is saved and restored, separate of the main window.
- I removed some more unneeded changes, hoping to preserve coding style as much as possible.

I'm not sure about the default size of the widget, I set it to 500x600, somewhat similar to what was the default size before.


Summary
-------

Change the script editor to use XmlGui for actions, with complete KTextEditor toolbars and menus.

The patch is a little rough still, with unneeded whitespace changes, I will probably update it soon. There are also some leftover debug calls and error checks. You can see the code and comment on it. I will also explain and/or correct any wtf-moments that may have occured. 

I realize that trunk is in a soft treeze right now, and that this isn't a killer feature, so I think there's no rush to get it commited. I would like some feedback on it.


Diffs (updated)
-----

  /trunk/KDE/kdeedu/cantor/src/scripteditorwidget.cpp 1123901 
  /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1123901 
  /trunk/KDE/kdeedu/cantor/src/cantor.cpp 1123901 
  /trunk/KDE/kdeedu/cantor/src/cantor_part.h 1123901 
  /trunk/KDE/kdeedu/cantor/src/cantor_part.cpp 1123901 
  /trunk/KDE/kdeedu/cantor/src/cantor_scripteditor.rc PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/scripteditorwidget.h 1123901 

Diff: http://reviewboard.kde.org/r/3878/diff


Testing
-------

The GUI looks and behaves properly. I tried some different ways of closing the script editor and the running session and it behaved as expected in all of them. 

It was tested with last week's trunk.


Screenshots
-----------

Script editor with KTextEditor's menus
  http://reviewboard.kde.org/r/3878/s/385/


Thanks,

Miha