[kde-edu]: Review Request: Audio for kwordquiz.
Peter Hedlund
peter at peterandlinda.com
Tue Mar 2 00:22:48 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2860/#review4332
-----------------------------------------------------------
I am wondering what is the most likely scenario or work flow for Q&A? Is it to play a sound associated with the question before or after answering the question? Both? I see that you have also started to consider what to do with a sound associated with the question. Would we actually need two play buttons?
For Flashcard it would be easier, right? Just play the sound associated with the side being displayed?
trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.cpp
<http://reviewboard.kde.org/r/2860/#comment3811>
The problem here is that the line edit always has focus. Key_A is then select all. Why Key_U gets eaten I don't know. Key_B is available and works, what do you think?
trunk/KDE/kdeedu/kwordquiz/src/qaview.cpp
<http://reviewboard.kde.org/r/2860/#comment3812>
The default is to play a sound notification for either correct or incorrect. Playing the associated sound here results in two sounds being played more or less on top of each other. I don't know what would be the best solution, what was your intent?
- Peter
On 2010-02-20 17:58:44, Stanislaw Gruszka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2860/
> -----------------------------------------------------------
>
> (Updated 2010-02-20 17:58:44)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> Basic functionality in (for qaview). Still some work to do: configuration, change Ctrl+P (Ctrl+U not work ?), downloading files, maybe more.
>
>
> Diffs
> -----
>
> trunk/KDE/kdeedu/kwordquiz/src/flashview.cpp 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.h 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.cpp 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwordquizui.rc 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwqquizmodel.h 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwqquizmodel.cpp 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwqtablemodel.h 1093098
> trunk/KDE/kdeedu/kwordquiz/src/kwqtablemodel.cpp 1093098
> trunk/KDE/kdeedu/kwordquiz/src/multipleview.cpp 1093098
> trunk/KDE/kdeedu/kwordquiz/src/qaview.h 1093098
> trunk/KDE/kdeedu/kwordquiz/src/qaview.cpp 1093098
>
> Diff: http://reviewboard.kde.org/r/2860/diff
>
>
> Testing
> -------
>
> Patch works. I note some strange system tray blinking, when playing audio. Looks phonon add icon to tray and remove it. Not investigate more.
>
>
> Thanks,
>
> Stanislaw
>
>
More information about the kde-edu
mailing list