[kde-edu]: Review Request: Titration calculator in Kalzium

[etienne.rebetez at oberwallis.ch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4667/#review6620
-----------------------------------------------------------


You can actualy add files to your local svn copy. If you don't alredy have one do:
$svn co svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu

add your files where you think they belong. Then use dolphin or
$svn add newfile1 newfile2

and do the patch
$svn diff > mypatch.diff

All this works without having a svn-account.

By the way, thanks for your code. I'll try to review it when i finde some time.

- eti


On 2010-07-17 07:26:12, Luca Tringali wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4667/
> -----------------------------------------------------------
> 
> (Updated 2010-07-17 07:26:12)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> These changes are needed to implement the titration calculator for kalzium. Anyway it's necessary to add the files titrationCalculator.cpp, titrationCalculator.h, titrationCalculator.ui (you can find it here http://zorbaproject.uuuq.com/upload/titrationCalculator.tar.gz) into the directory src/calculator/. I cannot do this because post-review allows only to edit existing files and not to add new files, and I do not have any svn account. 
> Tell me if I did something wrong.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kalzium/src/CMakeLists.txt 1145939 
>   /trunk/KDE/kdeedu/kalzium/src/calculator/calculator.h 1145939 
>   /trunk/KDE/kdeedu/kalzium/src/calculator/calculator.cpp 1145939 
>   /trunk/KDE/kdeedu/kalzium/src/calculator/calculator.ui 1145939 
> 
> Diff: http://reviewboard.kde.org/r/4667/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Titration example
>   http://reviewboard.kde.org/r/4667/s/460/
> 
> 
> Thanks,
> 
> Luca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100717/70f909d9/attachment.htm