[kde-edu]: Review Request: Tests for Cantor backends

[Miha Cancula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4616/
-----------------------------------------------------------

(Updated 2010-07-16 15:54:14.366733)


Review request for KDE-Edu and Alexander Rieder.


Changes
-------

Added CANTOR_EXPORT to backendtest.h and made libcantortest a shared library. Thanks Alexander for the suggestion. 

I re-used cantor's export macro because I don't think the test library will ever be compiled without cantorlibs.


Summary
-------

This patch introduces a BackendTest class which has the functionality previously shared by tests for Maxima and Sage backends. I also included a test for the new Octave backend, which also uses the same class. 

The only new functionality is skipping tests for backends which are not usable (either not installed or missing runtime requirements). Otherwise it's mostly copy/paste, so I kept Alexander's copyright in the new class. 


Diffs (updated)
-----

  /trunk/KDE/kdeedu/cantor/CMakeLists.txt 1149794 
  /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1149794 
  /trunk/KDE/kdeedu/cantor/src/backends/maxima/CMakeLists.txt 1149810 
  /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/octave/CMakeLists.txt 1149810 
  /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/sage/CMakeLists.txt 1149810 
  /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt 1149794 
  /trunk/KDE/kdeedu/cantor/src/lib/test/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testmaxima.h 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testsage.h 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testsage.cpp 1149809 

Diff: http://reviewboard.kde.org/r/4616/diff


Testing
-------

All three tests compile and run. Maxima's testPlot fails, but I think that happened before the change too. I don't have Sage installed, so its test is successfully skipped. 


Thanks,

Miha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100716/9981be25/attachment.htm