[kde-edu]: Review Request: Tests for Cantor backends

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4616/#review6601
-----------------------------------------------------------


Hi,
Overall the patch looks good, but one small note: now, if a backend is not installed, the test won't be compiled. So if the creating of the backend fails in a test, there must be some other problem, so i think there shouldn't be a Q_SKIP for it (anymore), but the test should fail instead.

As for the linker errors when creating shared library: you probably have to do some KDE_EXPORT magic, see  the macros in lib/cantor_export.h and http://techbase.kde.org/Development/Tutorials/Creating_Libraries for reference.

- Alexander


On 2010-07-15 16:51:24, Miha Cancula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4616/
> -----------------------------------------------------------
> 
> (Updated 2010-07-15 16:51:24)
> 
> 
> Review request for KDE-Edu and Alexander Rieder.
> 
> 
> Summary
> -------
> 
> This patch introduces a BackendTest class which has the functionality previously shared by tests for Maxima and Sage backends. I also included a test for the new Octave backend, which also uses the same class. 
> 
> The only new functionality is skipping tests for backends which are not usable (either not installed or missing runtime requirements). Otherwise it's mostly copy/paste, so I kept Alexander's copyright in the new class. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/cantor/CMakeLists.txt 1149794 
>   /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1149794 
>   /trunk/KDE/kdeedu/cantor/src/backends/maxima/CMakeLists.txt 1149810 
>   /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.h PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/backends/octave/CMakeLists.txt 1149810 
>   /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.h PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/backends/sage/CMakeLists.txt 1149810 
>   /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.h PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt 1149794 
>   /trunk/KDE/kdeedu/cantor/src/lib/test/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.h PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/lib/test/backendtest.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt 1149809 
>   /trunk/KDE/kdeedu/cantor/tests/testmaxima.h 1149809 
>   /trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp 1149809 
>   /trunk/KDE/kdeedu/cantor/tests/testsage.h 1149809 
>   /trunk/KDE/kdeedu/cantor/tests/testsage.cpp 1149809 
> 
> Diff: http://reviewboard.kde.org/r/4616/diff
> 
> 
> Testing
> -------
> 
> All three tests compile and run. Maxima's testPlot fails, but I think that happened before the change too. I don't have Sage installed, so its test is successfully skipped. 
> 
> 
> Thanks,
> 
> Miha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100715/953213bd/attachment-0001.htm