[kde-edu]: Review Request: Tests for Cantor backends

[Miha Cancula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4616/
-----------------------------------------------------------

(Updated 2010-07-14 17:53:51.727480)


Review request for KDE-Edu and Alexander Rieder.


Changes
-------

Moved the shared code into a library in src/lib/test and the individual tests to their backends. Note that the library is static rather than shared, since setting it to shared produces link errors. I'd be happy if anyone can tell why is that and if it's a bad thing. 

Unfortunately I forget to 'svn mv' the files, so they appear as new in the diff, but nothings is changed in the source files, only various CMakeLists.txt changes.


Summary
-------

This patch introduces a BackendTest class which has the functionality previously shared by tests for Maxima and Sage backends. I also included a test for the new Octave backend, which also uses the same class. 

The only new functionality is skipping tests for backends which are not usable (either not installed or missing runtime requirements). Otherwise it's mostly copy/paste, so I kept Alexander's copyright in the new class. 


Diffs (updated)
-----

  /trunk/KDE/kdeedu/cantor/CMakeLists.txt 1149794 
  /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1149794 
  /trunk/KDE/kdeedu/cantor/src/backends/maxima/CMakeLists.txt 1149810 
  /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/octave/CMakeLists.txt 1149810 
  /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/sage/CMakeLists.txt 1149810 
  /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt 1149794 
  /trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testmaxima.h 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testsage.h 1149809 
  /trunk/KDE/kdeedu/cantor/tests/testsage.cpp 1149809 

Diff: http://reviewboard.kde.org/r/4616/diff


Testing
-------

All three tests compile and run. Maxima's testPlot fails, but I think that happened before the change too. I don't have Sage installed, so its test is successfully skipped. 


Thanks,

Miha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100714/6e75efb6/attachment-0001.htm