[kde-edu]: Review Request: Tests for Cantor backends

Miha Cancula miha.cancula at gmail.com
Tue Jul 13 14:30:43 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4616/
-----------------------------------------------------------

Review request for KDE-Edu and Alexander Rieder.


Summary
-------

This patch introduces a BackendTest class which has the functionality previously shared by tests for Maxima and Sage backends. I also included a test for the new Octave backend, which also uses the same class. 

The only new functionality is skipping tests for backends which are not usable (either not installed or missing runtime requirements). Otherwise it's mostly copy/paste, so I kept Alexander's copyright in the new class. 


Diffs
-----

  /trunk/KDE/kdeedu/cantor/tests/testoctave.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/tests/testoctave.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/tests/testmaxima.h 1149413 
  /trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp 1149413 
  /trunk/KDE/kdeedu/cantor/tests/backendtest.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt 1149413 
  /trunk/KDE/kdeedu/cantor/tests/backendtest.h PRE-CREATION 
  /trunk/KDE/kdeedu/cantor/tests/testsage.h 1149413 
  /trunk/KDE/kdeedu/cantor/tests/testsage.cpp 1149413 

Diff: http://reviewboard.kde.org/r/4616/diff


Testing
-------

All three tests compile and run. Maxima's testPlot fails, but I think that happened before the change too. I don't have Sage installed, so its test is successfully skipped. 


Thanks,

Miha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100713/931cce4f/attachment.htm 


More information about the kde-edu mailing list