[kde-edu]: Review Request: Findlibgps.cmake: avoid use of deprecated FindPkgConfig
Bastian Holst
bastianholst at gmx.de
Tue Jul 6 16:50:53 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4498/#review6387
-----------------------------------------------------------
Ship it!
Looks good to me.
- Bastian
On 2010-06-29 23:09:56, Max wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4498/
> -----------------------------------------------------------
>
> (Updated 2010-06-29 23:09:56)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> Rewrite Findlibgps.cmake without using PkgConfig in accordance with http://techbase.kde.org/Policies/CMake_Coding_Style.
>
>
> Diffs
> -----
>
> trunk/KDE/kdeedu/marble/Findlibgps.cmake 1144439
> trunk/KDE/kdeedu/marble/src/plugins/positionprovider/CMakeLists.txt 1144439
> trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/CMakeLists.txt 1144439
>
> Diff: http://reviewboard.kde.org/r/4498/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Max
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100706/e0d01236/attachment.htm
More information about the kde-edu
mailing list