[kde-edu]: Review Request: Parley : Fix for bug 183468

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2545/#review3685
-----------------------------------------------------------

Ship it!


Looks good :)
Thanks!

- Frederik


On 2010-01-10 22:11:56, Nicolas Réau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2545/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 22:11:56)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> Fix for bug 183468 for Parley. The column now resize themselves according to content and so the content is not truncated and the user no more owned because he can't resize it.
> 
> ResizeToContents could be replaced with Interactive which let the user resize manually the column, but in this case the columns' size wouldn't be optimized at first and could look truncated (even if the user could resize it).
> 
> I think it's better to immediately optimize the width of the column.
> 
> Note:2 lines about resizing columns were commented, so I wonder if there was previous problem with it.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=183468.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=183468
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/parley/src/statistics-dialogs/lessonstatistics.cpp 1072122 
> 
> Diff: http://reviewboard.kde.org/r/2545/diff
> 
> 
> Testing
> -------
> 
> The content is no more truncated with long word since the column size fits the content. It works here.
> 
> 
> Thanks,
> 
> Nicolas
> 
>