[kde-edu]: Review Request: KWordQuiz: crash when opening CVS files that don't contain TAB characters

[Peter Hedlund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2572/#review3684
-----------------------------------------------------------

Ship it!


Thank you!

- Peter


On 2010-01-13 13:46:08, Aleks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2572/
> -----------------------------------------------------------
> 
> (Updated 2010-01-13 13:46:08)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> After KEduVocCsvReader::readDoc returns, m_doc->identifierCount() is either zero (an empty file) or 1 (only one TAB as the very last character). In either cases a crash occurs later on when KWQTableModel::headerData processes a non-existent m_doc->identifier(0).
> P.S. Parley is not affected 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.cpp 1074115 
> 
> Diff: http://reviewboard.kde.org/r/2572/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleks
> 
>