[kde-edu]: Review Request: Prevent KwordQuiz crash when opening CVS files that dont contain <TAB> characters
Aleks
aletum at lavabit.com
Wed Jan 13 14:19:24 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2569/
-----------------------------------------------------------
(Updated 2010-01-13 13:19:24.609978)
Review request for KDE-Edu.
Changes
-------
More optimized code
Summary
-------
After KEduVocCsvReader::readDoc returns, m_doc->identifierCount() is either zero (an empty file) or 1 (only one TAB as the very last character). In either cases a crash occurs later on when KWQTableModel::headerData processes a non-existent m_doc->identifier(0).
P.S. Parley is not affected
Diffs (updated)
-----
/trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.cpp 1074106
Diff: http://reviewboard.kde.org/r/2569/diff
Testing
-------
Thanks,
Aleks
More information about the kde-edu
mailing list