[kde-edu]: Review Request: [Parley-branch] Display as many choices as set in the config options of multiple-choices mode

Nicolas Réau thelwyn at gmail.com
Sun Feb 21 19:17:48 CET 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-02-21 18:17:47.965527)

Review request for KDE-Edu and Frederik Gladhorn.


Removed lots of useless code thanks to dani_l input. It's now all located into multiplechoicewidget.


The radio buttons in multiple choice mode are now displayed according to the option set by the user in the config dialog (instead of being hardcoded to 5 choices).

Diffs (updated)

  branches/work/parley-practice/parley/src/practice/multiplechoicemodewidget.h 1093868 
  branches/work/parley-practice/parley/src/practice/multiplechoicemodewidget.cpp 1093868 
  branches/work/parley-practice/parley/src/practice/practice_widget_multiplechoice.ui 1093868 

Diff: http://reviewboard.kde.org/r/2852/diff


It works fine here. However I'm not satisfied of my code: I feel like I'm touching some files i shouldn't have too.

Please review it and tell if it's bad implemented or how it can be improved. (btw I've not removed my debug messages from the diff yet).



More information about the kde-edu mailing list