[kde-edu]: Review Request: KWordQuiz: new feature Language Tutor

Aleks abirvalg at lavabit.com
Mon Feb 15 22:19:28 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2822/
-----------------------------------------------------------

(Updated 2010-02-15 21:19:28.669114)


Review request for KDE-Edu.


Changes
-------

Thank you Peter for your tips.
I had a lot of fun coming to grips with QtDesigner, I think I've got a good hang on if it now. (I also managed to find a rather serious glitch in QTDesigner which I filed here http://bugreports.qt.nokia.com/browse/QTBUG-8212 ). Anyway, QGraphicsView requires some manipulations with scaling the font of text proportionately to the window size, otherwise long entries get cropped. No good :(
Also I was wondering about OOP-style policy. Do all object properties have to be encapsulated into get/set functions. I find it adds some unnecessary code overhead. On the other hand, Gnome has started a code review project to substitute all data with get/set funcs. Just FYI.


Summary
-------

A feature which pops up words randomly at certain time intervals.
It is implemented through a -g tutor [file] command line switch.
It creates a trayicon. When user presses start menu item, a window pops up at an interval defined in Preferences. There are two GlobalShortcut bindings, one for closing the flashcard, another for showing the reverse side.
It might not be prudent to load the whole binary into memory if one wants to run just the Tutor, so there is an option of implemeting this Tutor as a stand-alone program.
Also the Preferences Dialog is not yet finished and the Settings dont get saved upon exit.
I just wanted to here people's comments and suggestions before I tidy up the code.

KWQTutor class creates a SysTray, Menu and connects menu items to SLOTs.
startstoppressed SLOT displays the QLabel (the flashcard itself) with the text.


Diffs (updated)
-----

  /trunk/KDE/kdeedu/kwordquiz/src/CMakeLists.txt 1090268 
  /trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.kcfg 1090268 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.ui PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorflashcard.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorflashcard.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorwelcome.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorwelcome.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorwelcome.ui PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/main.cpp 1090268 

Diff: http://reviewboard.kde.org/r/2822/diff


Testing
-------


Thanks,

Aleks



More information about the kde-edu mailing list