[kde-edu]: Review Request: KWordQuiz: new feature Language Tutor

[Aleks]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2822/
-----------------------------------------------------------

(Updated 2010-02-12 21:01:14.777048)


Review request for KDE-Edu.


Changes
-------

Hello, here's a finished product.
All suggestions were implemented:
- memory leak found and fixed
- welcome dialog at first run
- option between KWQCardView and QLabel
- unfortunately there are no menu items, one of the reason being that I don't see KWordQuiz menu items as it is, because I use Gnome and there is some issue with KDE icons in menus, second reason being...do I have to draw those icons myself? I wouldn't mind, but I've never done this.
Also KWQCardView-based flashcards could be made more flexible, to scale down when an entry is too long. Long entries don't fit entirely.
Please advise as to any other improvements that I could make.
Thanks.


Summary
-------

A feature which pops up words randomly at certain time intervals.
It is implemented through a -g tutor [file] command line switch.
It creates a trayicon. When user presses start menu item, a window pops up at an interval defined in Preferences. There are two GlobalShortcut bindings, one for closing the flashcard, another for showing the reverse side.
It might not be prudent to load the whole binary into memory if one wants to run just the Tutor, so there is an option of implemeting this Tutor as a stand-alone program.
Also the Preferences Dialog is not yet finished and the Settings dont get saved upon exit.
I just wanted to here people's comments and suggestions before I tidy up the code.

KWQTutor class creates a SysTray, Menu and connects menu items to SLOTs.
startstoppressed SLOT displays the QLabel (the flashcard itself) with the text.


Diffs (updated)
-----

  /trunk/KDE/kdeedu/kwordquiz/src/CMakeLists.txt 1084846 
  /trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.kcfg 1084846 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorflashcard.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorlabel.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorwelcome.h PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorwelcome.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorwelcome.ui PRE-CREATION 
  /trunk/KDE/kdeedu/kwordquiz/src/main.cpp 1084846 
  /trunk/KDE/kdeedu/kwordquiz/src/tutorform.ui PRE-CREATION 

Diff: http://reviewboard.kde.org/r/2822/diff


Testing
-------


Thanks,

Aleks