[kde-edu]: Review Request: KWordQuiz: new feature Language Tutor
Peter Hedlund
peter at peterandlinda.com
Fri Feb 5 20:18:02 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2822/#review4078
-----------------------------------------------------------
Good, I have now been able to do some initial testing.
All my comments from yesterday remain plus a few more below.
There is a memory leak somewhere...
For future reference:
1. some sort of greeting when used the first time.
2. ability to start the tutor from within KWQ.
3. I like menu icons.
/trunk/KDE/kdeedu/kwordquiz/src/CMakeLists.txt
<http://reviewboard.kde.org/r/2822/#comment3591>
Your diff is not against HEAD. Please correct.
/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3592>
i18n() here and for all user visible strings. Also indicate context.
/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3594>
Use standard action for open
/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3595>
use standard action for quit
/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3593>
This conflicts with the system default for switching keyboard layouts.
- Peter
On 2010-02-05 08:14:35, Aleks wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2822/
> -----------------------------------------------------------
>
> (Updated 2010-02-05 08:14:35)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> A feature which pops up words randomly at certain time intervals.
> It is implemented through a -g tutor [file] command line switch.
> It creates a trayicon. When user presses start menu item, a window pops up at an interval defined in Preferences. There are two GlobalShortcut bindings, one for closing the flashcard, another for showing the reverse side.
> It might not be prudent to load the whole binary into memory if one wants to run just the Tutor, so there is an option of implemeting this Tutor as a stand-alone program.
> Also the Preferences Dialog is not yet finished and the Settings dont get saved upon exit.
> I just wanted to here people's comments and suggestions before I tidy up the code.
>
> KWQTutor class creates a SysTray, Menu and connects menu items to SLOTs.
> startstoppressed SLOT displays the QLabel (the flashcard itself) with the text.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/kwordquiz/src/CMakeLists.txt 1084846
> /trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.kcfg 1084846
> /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.h PRE-CREATION
> /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp PRE-CREATION
> /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.h PRE-CREATION
> /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.cpp PRE-CREATION
> /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorlabel.h PRE-CREATION
> /trunk/KDE/kdeedu/kwordquiz/src/main.cpp 1084846
> /trunk/KDE/kdeedu/kwordquiz/src/tutorform.ui PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/2822/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleks
>
>
More information about the kde-edu
mailing list