[kde-edu]: Review Request: KWordQuiz: new feature Language Tutor

[Peter Hedlund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2822/#review4055
-----------------------------------------------------------


Due to a missing ui file I can't compile this, but I like the idea. See below for some initial comments.


/trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.kcfg
<http://reviewboard.kde.org/r/2822/#comment3531>

    Consider using a QPoint



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.h
<http://reviewboard.kde.org/r/2822/#comment3533>

    Use this type of camelCase for all variables



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.h
<http://reviewboard.kde.org/r/2822/#comment3532>

    m_tutorDoc ?



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3534>

    Would it be possible to use KWQCardView/Scene?



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3535>

    See KIconLoader for how to properly load icons.



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3536>

    Consider using KRandom/KRandomSequence for portability.



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp
<http://reviewboard.kde.org/r/2822/#comment3537>

    See kwordquiz.cpp for how to use QPointer here (krazy will complain otherwise).



/trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.h
<http://reviewboard.kde.org/r/2822/#comment3538>

    The ui file is missing so I can't compile.


- Peter


On 2010-02-03 21:58:51, Aleks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2822/
> -----------------------------------------------------------
> 
> (Updated 2010-02-03 21:58:51)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> A feature which pops up words randomly at certain time intervals.
> It is implemented through a -g tutor [file] command line switch.
> It creates a trayicon. When user presses start menu item, a window pops up at an interval defined in Preferences. There are two GlobalShortcut bindings, one for closing the flashcard, another for showing the reverse side.
> It might not be prudent to load the whole binary into memory if one wants to run just the Tutor, so there is an option of implemeting this Tutor as a stand-alone program.
> Also the Preferences Dialog is not yet finished and the Settings dont get saved upon exit.
> I just wanted to here people's comments and suggestions before I tidy up the code.
> 
> KWQTutor class creates a SysTray, Menu and connects menu items to SLOTs.
> startstoppressed SLOT displays the QLabel (the flashcard itself) with the text.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwordquiz.kcfg 1084846 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.h PRE-CREATION 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwqtutor.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.h PRE-CREATION 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwqtutordialog.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/kwordquiz/src/kwqtutorlabel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/kwordquiz/src/main.cpp 1084846 
> 
> Diff: http://reviewboard.kde.org/r/2822/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleks
> 
>