[kde-edu]: Re: Review Request: Create an "About" dialog for the coordinate grid plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6161/#review9322
-----------------------------------------------------------

Ship it!


Looks good except for the minor issues below.


/trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp
<http://svn.reviewboard.kde.org/r/6161/#comment10316>

    heh,
    "bholst" is actually the login of another Marble developer. My login would be "tackat" or "trahn". Maybe we should just call the variable "author".



/trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp
<http://svn.reviewboard.kde.org/r/6161/#comment10317>

    There is no data in this plugin. So this call can be omitted


- Torsten


On 2010-12-19 14:51:42, Cezar Mocan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6161/
> -----------------------------------------------------------
> 
> (Updated 2010-12-19 14:51:42)
> 
> 
> Review request for KDE-Edu, marble and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> Create an "About" dialog for the coordinate grid plugin
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.h 1201473 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp 1201473 
> 
> Diff: http://svn.reviewboard.kde.org/r/6161/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cezar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20101219/9dcbb8ab/attachment-0001.htm