[kde-edu]: Re: Review Request: Cantor: Use default backend if pressing "New" and provide a menu "New" to create worksheet with specific backend

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6121/#review9305
-----------------------------------------------------------


the code looks good. unfortunately this will have to wait until trunk is open again for 4.7

- Alexander


On 2010-12-15 18:12:50, Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6121/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 18:12:50)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> 1) Use the default backend when creating a new worksheet. It only asks for the default backend if no default backend is given (changed that to the default in the config file, to ask for the backend when Cantor is started the first time).
> 2) Change addWorksheet() to display the newly created tab.
> 3) Add a menu to the file menu with a list of the available and enabled backends to create a new worksheet with a specific backend.
> 
> 
> This addresses bug 225726.
>     https://bugs.kde.org/show_bug.cgi?id=225726
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/cantor/src/cantor.cpp 1206532 
>   trunk/KDE/kdeedu/cantor/src/cantor.kcfg 1206532 
>   trunk/KDE/kdeedu/cantor/src/cantor_shell.rc 1206532 
> 
> Diff: http://svn.reviewboard.kde.org/r/6121/diff
> 
> 
> Testing
> -------
> 
> Tested and it was fine.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20101218/2585eb73/attachment.htm