[kde-edu]: Re: Review Request: GeoDataLatLonAltBox Unit Test

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6077/#review9193
-----------------------------------------------------------


That's a very good start for more tests in GeoData, thanks!
Please consider adding marble as review group, we other marblers pay more attention to marble specific dev there.


/trunk/KDE/kdeedu/marble/tests/CMakeLists.txt
<http://svn.reviewboard.kde.org/r/6077/#comment10031>

    I think this one didn't make it in this patch.



/trunk/KDE/kdeedu/marble/tests/CMakeLists.txt
<http://svn.reviewboard.kde.org/r/6077/#comment10032>

    For consistency with other tests, you should rename to match the same pattern as other TestGeoDataxxx.



/trunk/KDE/kdeedu/marble/tests/unittest_geodatalatlonaltbox.cpp
<http://svn.reviewboard.kde.org/r/6077/#comment10033>

    The comment should be better off close to the implementation.



/trunk/KDE/kdeedu/marble/tests/unittest_geodatalatlonaltbox.cpp
<http://svn.reviewboard.kde.org/r/6077/#comment10035>

    Why not using the enum GeoDataCoordinates instead of a string?
    Could this spare the code duplication for degree vs radian?



/trunk/KDE/kdeedu/marble/tests/unittest_geodatalatlonaltbox.cpp
<http://svn.reviewboard.kde.org/r/6077/#comment10034>

    qrand per doc returns between 0 and stdlib.h RAND_MAX.
    
    What is this code trying to achieve? Why not test also extreme negative values?


- Thibaut


On 2010-12-09 16:32:26, Cezar Mocan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6077/
> -----------------------------------------------------------
> 
> (Updated 2010-12-09 16:32:26)
> 
> 
> Review request for KDE-Edu and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> GeoDataLatLonAltBox Unit Test
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1204817 
>   /trunk/KDE/kdeedu/marble/tests/unittest_geodatalatlonaltbox.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6077/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cezar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20101211/c9b86350/attachment.htm