[kde-edu]: Review Request: Titration calculator in Kalzium

[Luca Tringali]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4667/
-----------------------------------------------------------

(Updated 2010-08-09 21:17:58.654953)


Review request for KDE-Edu.


Changes
-------

Ok Etienne, I did the changes you suggested, I'll explain every changes in another mail.


Summary
-------

These changes are needed to implement the titration calculator for kalzium. Anyway it's necessary to add the files titrationCalculator.cpp, titrationCalculator.h, titrationCalculator.ui (you can find it here http://zorbaproject.uuuq.com/upload/titrationCalculator.tar.gz) into the directory src/calculator/. I cannot do this because post-review allows only to edit existing files and not to add new files, and I do not have any svn account. 
Tell me if I did something wrong.


Diffs (updated)
-----

  /trunk/KDE/kdeedu/kalzium/src/CMakeLists.txt 1145939 
  /trunk/KDE/kdeedu/kalzium/src/calculator/calculator.h 1145939 
  /trunk/KDE/kdeedu/kalzium/src/calculator/calculator.cpp 1145939 
  /trunk/KDE/kdeedu/kalzium/src/calculator/calculator.ui 1145939 
  /trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.h PRE-CREATION 
  /trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/kalzium/src/calculator/titrationCalculator.ui PRE-CREATION 

Diff: http://reviewboard.kde.org/r/4667/diff


Testing
-------


Screenshots
-----------

Titration example
  http://reviewboard.kde.org/r/4667/s/460/


Thanks,

Luca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100809/8d43d262/attachment.htm