[kde-edu]: Review Request: [KAnagram] Ported to Get Hot new Stuff 3

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3485/#review4870
-----------------------------------------------------------

Ship it!


I think having the download button on the vocabularies page is more logical in the end. Thanks!
I'll leave it up to Jeremy to take care of the rest now ;)
Uninstall is broken here as well, I'll look into it.


/trunk/KDE/kdeedu/kanagram/src/vocabsettings.cpp
<http://reviewboard.kde.org/r/3485/#comment4355>

    refresh view seems to take forever. maybe just call it if the user actually changed something? if (dialog.changedEntries().size() > 0)


- Frederik


On 2010-04-03 23:04:30, eti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3485/
> -----------------------------------------------------------
> 
> (Updated 2010-04-03 23:04:30)
> 
> 
> Review request for KDE-Edu and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> Finally i found some time to finish my homework from the last klassroom;)
> KAnagram is now ported to "Get hot new Stuff 3". 
> I also did a small UI change in the configuration dialog.
> 
> Let me know if you like it.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kanagram/src/CMakeLists.txt 1110654 
>   /trunk/KDE/kdeedu/kanagram/src/kanagram.cpp 1110654 
>   /trunk/KDE/kdeedu/kanagram/src/kanagram.knsrc 1110654 
>   /trunk/KDE/kdeedu/kanagram/src/newstuff.h 1110509 
>   /trunk/KDE/kdeedu/kanagram/src/newstuff.cpp 1110509 
>   /trunk/KDE/kdeedu/kanagram/src/newstuffwidget.ui 1110509 
>   /trunk/KDE/kdeedu/kanagram/src/vocabsettings.h 1110654 
>   /trunk/KDE/kdeedu/kanagram/src/vocabsettings.cpp 1110654 
>   /trunk/KDE/kdeedu/kanagram/src/vocabsettingswidget.ui 1110654 
> 
> Diff: http://reviewboard.kde.org/r/3485/diff
> 
> 
> Testing
> -------
> 
> Somehow deinstalling the vocas dosn't work. They remain in the home folder.
> Is this a GHNS3 Bug or did i forgot something?
> 
> 
> Thanks,
> 
> eti
> 
>