[kde-edu]: Step: Bug in buildsystem?

Philippe Widmer phwidmer at gmail.com
Sat Apr 5 21:38:20 CEST 2008


hi,

On Saturday 05 April 2008 21.17:37 Tomaz Canabrava wrote:
> hm...
> IMHO, but I could be wrong, it should be like...
>
> --- cmake/modules/FindGMM.cmake	(revision 793929)
> +++ cmake/modules/FindGMM.cmake	(working copy)
> @@ -10,6 +10,7 @@
>      if(NOT GMM_FIND_QUIETLY)
>        message(STATUS "Found GMM++: ${GMM_INCLUDE_DIR}")
> +     set(GMM_FOUND TRUE)
>      endif(NOT GMM_FIND_QUIETLY)
>  else(GMM_INCLUDE_DIR)
>      if(GMM_FIND_REQUIRED)
>        message(FATAL_ERROR "Could NOT find GMM++")
>
>
> the set should be inside of the if.

but this would set GMM_FOUND only if GMM_FIND_QUIETLY is set and I think the 
latter defines wether such status messages should be output or not (Though I 
don't know if that's true). If so, I'd assume we want to set GMM_FOUND 
always, no matter wether we output status message or not, don't we?

phil


More information about the kde-edu mailing list