[multimedia/k3b] src: JobProgressDialog: Clarify the wording when cancelling the operation

Jonathan Marten null at kde.org
Tue Jan 13 12:15:32 GMT 2026


Git commit a33dcf2aa44d4f34579c3d1dbf29d7a6943bfc9c by Jonathan Marten.
Committed on 13/01/2026 at 12:14.
Pushed by marten into branch 'master'.

JobProgressDialog: Clarify the wording when cancelling the operation

There was originally a confusing negation where clicking "Cancel" on the
progress dialogue prompted "Do you really want to cancel?" with buttons
"OK" and "Cancel".  The "OK" button is the one that actually cancels the
operation, while "Cancel" would cancel the question dialogue and continue
with the operation.  Reword stopping the operation to "Stop" and explicitly
state the button options so as to avoid the confusion of using "Cancel".

GUI:
I18N:

M  +7    -4    src/k3bjobprogressdialog.cpp

https://invent.kde.org/multimedia/k3b/-/commit/a33dcf2aa44d4f34579c3d1dbf29d7a6943bfc9c

diff --git a/src/k3bjobprogressdialog.cpp b/src/k3bjobprogressdialog.cpp
index 2be548999..6de7aa724 100644
--- a/src/k3bjobprogressdialog.cpp
+++ b/src/k3bjobprogressdialog.cpp
@@ -226,6 +226,7 @@ void K3b::JobProgressDialog::setupGUI()
     QDialogButtonBox* buttonBox = new QDialogButtonBox( this );
     m_cancelButton = buttonBox->addButton( QDialogButtonBox::Cancel );
     connect( m_cancelButton, SIGNAL(clicked()), this, SLOT(reject()) );
+    m_cancelButton->setText(i18nc("@action:button to stop the operation", "Stop"));
 
     m_showDbgOutButton = buttonBox->addButton( i18n("Show Debugging Output"), QDialogButtonBox::NoRole );
     m_showDbgOutButton->setIcon(QIcon::fromTheme("tools-report-bug"));
@@ -482,10 +483,12 @@ void K3b::JobProgressDialog::reject()
 {
     if( m_job && m_job->active() ) {
         if( KMessageBox::questionTwoActions( this,
-                                             i18n("Do you really want to cancel?"),
-                                             i18n("Cancel Confirmation"),
-                                             KStandardGuiItem::ok(),
-                                             KStandardGuiItem::cancel()) == KMessageBox::PrimaryAction ) {
+                                             i18n("Do you really want to stop the current operation in progress?"),
+                                             i18n("Confirm Stop Operation"),
+                                             KGuiItem(i18nc("@action:button to stop the operation", "Stop operation"),
+                                                      KStandardGuiItem::cancel().icon()),
+                                             KGuiItem(i18nc("@action:button to continue the operation", "Continue operation"),
+                                                      KStandardGuiItem::cont().icon())) == KMessageBox::PrimaryAction ) {
             if( m_job ) {
                 m_job->cancel();
                 m_closeButton->setEnabled(true);


More information about the kde-doc-english mailing list