[office/kmymoney] /: Remove Tip of the day feature

Thomas Baumgart null at kde.org
Mon Sep 27 19:07:11 BST 2021


Git commit 7e3be95666b063f94a6fea182fa6c43e48df8582 by Thomas Baumgart, on behalf of Alexander Lohnau.
Committed on 27/09/2021 at 18:07.
Pushed by tbaumgart into branch 'master'.

Remove Tip of the day feature

M  +0    -17   doc/firsttime.docbook
M  +0    -4    kmymoney/CMakeLists.txt
M  +0    -1    kmymoney/icons/icons.cpp
M  +0    -10   kmymoney/kmymoney.cpp
M  +0    -2    kmymoney/kmymoney.h
M  +0    -4    kmymoney/main.cpp
D  +0    -138  kmymoney/tips

https://invent.kde.org/office/kmymoney/commit/7e3be95666b063f94a6fea182fa6c43e48df8582

diff --git a/doc/firsttime.docbook b/doc/firsttime.docbook
index f9f483297..33343b249 100644
--- a/doc/firsttime.docbook
+++ b/doc/firsttime.docbook
@@ -14,23 +14,6 @@
 <sect1 id="firstime-1">
 <title>Running &kmymoney; for the first time</title>
 
-<para>
-  Once &kmymoney; has fully loaded two windows will be opened. The top window,
-  'Tip of the Day' offers one of a series of important or useful pieces of
-  information about the application.
-  <screenshot>
-	<screeninfo>Tip of the Day</screeninfo>
-	<mediaobject>
-	<imageobject>
-	<imagedata fileref="tipofday.png" format="PNG" />
-	</imageobject>
-	<textobject>
-	<phrase>Tip of the Day</phrase>
-	</textobject>
-	</mediaobject>
-  </screenshot>
-</para>
-
 <para>
   You are recommended to quickly read through these tips by pressing on the
   <guibutton>Previous</guibutton> and <guibutton>Next</guibutton> buttons at the
diff --git a/kmymoney/CMakeLists.txt b/kmymoney/CMakeLists.txt
index 1fc7aa100..1bb39a1e3 100644
--- a/kmymoney/CMakeLists.txt
+++ b/kmymoney/CMakeLists.txt
@@ -220,10 +220,6 @@ install(FILES org.kde.kmymoney.appdata.xml
 install(FILES x-kmymoney.xml
   DESTINATION ${XDG_MIME_INSTALL_DIR})
 
-install(FILES
-   tips
-   DESTINATION ${CMAKE_INSTALL_DATADIR}/kmymoney)
-
 #UPDATE_XDG_MIMETYPES(${XDG_MIME_INSTALL_DIR})
 
 
diff --git a/kmymoney/icons/icons.cpp b/kmymoney/icons/icons.cpp
index cc03859ab..b74ac4b7c 100644
--- a/kmymoney/icons/icons.cpp
+++ b/kmymoney/icons/icons.cpp
@@ -111,7 +111,6 @@ const QHash<Icon, QString> iconMappings{
     {Icon::TaskComplete, QStringLiteral("task-complete")},
     {Icon::TaskOngoing, QStringLiteral("task-ongoing")},
     {Icon::TaskReject, QStringLiteral("task-reject")},
-    {Icon::Tip, QStringLiteral("ktip")},
     {Icon::Unknown, QStringLiteral("unknown")},
     {Icon::UnmapOnlineAccount, QStringLiteral("network-disconnect")},
     {Icon::UserProperties, QStringLiteral("user-properties")},
diff --git a/kmymoney/kmymoney.cpp b/kmymoney/kmymoney.cpp
index f5479383f..84c55d92f 100644
--- a/kmymoney/kmymoney.cpp
+++ b/kmymoney/kmymoney.cpp
@@ -59,7 +59,6 @@
 #include <KRecentDirs>
 #include <KRecentFilesAction>
 #include <KStandardAction>
-#include <KTipDialog>
 #include <KToolBar>
 #include <KUndoActions>
 #include <KXMLGUIFactory>
@@ -1856,10 +1855,6 @@ QHash<Action, QAction *> KMyMoneyApp::initActions()
             // The settings menu
             // *****************
             {Action::SettingsAllMessages,           &KMyMoneyApp::slotEnableMessages},
-            // *************
-            // The help menu
-            // *************
-            {Action::HelpShow,                      &KMyMoneyApp::slotShowTipOfTheDay},
             // ***************************
             // Actions w/o main menu entry
             // ***************************
@@ -3433,11 +3428,6 @@ void KMyMoneyApp::slotBackupHandleEvents()
     }
 }
 
-void KMyMoneyApp::slotShowTipOfTheDay()
-{
-    KTipDialog::showTip(d->m_myMoneyView, "", true);
-}
-
 void KMyMoneyApp::slotGenerateSql()
 {
 //  QPointer<KGenerateSqlDlg> editor = new KGenerateSqlDlg(this);
diff --git a/kmymoney/kmymoney.h b/kmymoney/kmymoney.h
index ecd11f204..b792ed2da 100644
--- a/kmymoney/kmymoney.h
+++ b/kmymoney/kmymoney.h
@@ -200,8 +200,6 @@ protected Q_SLOTS:
       */
     void slotBackupHandleEvents();
 
-    void slotShowTipOfTheDay();
-
     /**
       * Call this slot, if any configuration parameter has changed
       */
diff --git a/kmymoney/main.cpp b/kmymoney/main.cpp
index 7bd6db566..e76d8ac92 100644
--- a/kmymoney/main.cpp
+++ b/kmymoney/main.cpp
@@ -25,7 +25,6 @@
 // ----------------------------------------------------------------------------
 // KDE Includes
 
-#include <KTipDialog>
 #include <KLocalizedString>
 #include <KMessageBox>
 #include <Kdelibs4ConfigMigrator>
@@ -332,9 +331,6 @@ int runKMyMoney(QApplication &a, const QUrl &file, bool noFile)
         }
 
         if (url.isValid() && !noFile) {
-            if (importfile.isEmpty()) {
-                KTipDialog::showTip(kmymoney, QString(), false);
-            }
             kmymoney->slotFileOpenRecent(url);
 
         } else if (KMyMoneySettings::firstTimeRun()) {
diff --git a/kmymoney/tips b/kmymoney/tips
deleted file mode 100644
index ab0a720ba..000000000
--- a/kmymoney/tips
+++ /dev/null
@@ -1,138 +0,0 @@
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can change the sort order of ledger entries by
-right-clicking the header of the ledger view?
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can easily move to the other side of a transfer transaction
-by opening the context menu with the right mouse button and selecting one of the
-'Goto' functions?
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can start editing a transaction by double-clicking on the
-transaction in the register?
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can show more details of the selected transaction in the
-register by selecting the 'ledger lens' feature in the settings dialog?
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that transactions with no category assigned or split
-transactions with unassigned values are marked with an exclamation mark 
-on a yellow triangle in the register?
-</html>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can show all details of the transactions in the register
-by typing <Ctrl-T> or selecting the 'View -> Show Transaction Detail'
-menu entry? You can turn this feature off the same way.
-</html>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that you can switch between a listing of all accounts or
-an icon view of all asset and liability accounts with the tabs
-in the accounts view?
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that the KMyMoney development team wishes you a nice day?
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...you can use your own external filter program to convert any
-import format to QIF on the fly? See the QIF profile editor for
-more details.
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can create a scheduled transaction from an existing
-one by selecting the context menu on a transaction in the ledger
-or the "More..."-menu in the transaction form?
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can switch to the payee of a transaction
-by selecting the context menu on a transaction in the ledger
-or in the transaction menu?
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that you can modify the colors and fonts used for the ledgers
-via <i>Configure/Colors and Fonts</i>?
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that you can hide transactions prior to a specific date?
-The date can be modified via <i>Configure/General/Filter</i>.
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that you can customize the "Home-Page"
-via <i>Configure/Home</i>?
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that you can add more data columns to accounts tables
-on your "Home-Page" via <i>Configure/Home/Account information display</i>?
-</html>
-</tip>
-
-<tip category="KMyMoney|Ledger">
-<html>
-<p>...that you can enter new transactions even while reconciling
-an account? You can also make the transaction form visible.
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>...that you can actively support the KMyMoney development team in
-cases that heavily depend on your data? You can save your data in an
-anonymized way for this support.<p>
-Just open your data file and immediately
-select <b>File/Save as...</b>. In the <b>Save As...</b> dialog
-select the filter <b>Anonymous Files</b> and make sure your file gets
-the extensions <b>.anon.xml</b>. <p>
-To verify, how the data looks like you are about to send away, you can open
-this file in KMyMoney and see how the developers see your data.
-</html>
-</tip>
-
-<tip category="KMyMoney|General">
-<html>
-<p>... that you can import your bank statements even without a network 
-connection? Just select the file (OFX or QIF) from the File->Import menu.</p>
-<p>Provided by Jose Jorge</p>
-</html>
-</tip>
-


More information about the kde-doc-english mailing list