D22594: [Dolphin] Open Preferred Search Tool action

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:943
>      KJobWidgets::setWindow(statJob, this);
>      statJob->exec();
>      QUrl url = statJob->mostLocalUrl();

`exec()` on a job is generally bad, but looks like it was like this already?

> dolphinmainwindow.cpp:2289
>          return true;
> +    } else if (event->type() == QEvent::WindowActivate) {
> +        updateOpenPreferredSearchToolAction();

This causes quite severe bug https://bugs.kde.org/show_bug.cgi?id=420911
Why is this needed anyway, we already monitor `aboutToShow` for all the relevant menus, no?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: broulik, pkloc, kfm-devel, kde-doc-english, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20200504/7e707971/attachment.html>