D27973: kcddb 6

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  In D27973#626226 <https://phabricator.kde.org/D27973#626226>, @aacid wrote:
  
  > In D27973#625703 <https://phabricator.kde.org/D27973#625703>, @sitter wrote:
  >
  > > Looks reasonable.
  > >  Do you think it'd make sense to mark the remaining classes deprecated? If the long term goal is to drop the lib entirely and have people use musicbrainz directly I figure we should communicate that.
  >
  >
  > I agree and disagree :)
  >
  > I think libkcddb needs to die, since it's basically built around the cddb service which is shutting down, i mean the musicbrainz support was optional until this change.
  >
  > Otherwise I'm not sure if suggesting people to use libmusicbrainz directly is the best idea and maybe we need something intermediate? I mean if you look at MusicBrainzLookup::calculateDiscId that's something i wouldn't want everyone to have to implement themselves
  
  
  Fair point. Writing an intermediate library is extra work that I fear will not happen unless there's reason to, so my thinking was having kcddb deprecated so it annoys one of the developers that use it into making libqmusicbrainz as a replacement ;). Scratching their own itch, as it were.
  
  +1 to the diff though. In particular also +1 to the dependency change, it could be landed on its own to at least get that in before dep freeze.

REPOSITORY
  R348 KCDDB Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27973

To: aacid, sitter
Cc: wbauer, pino, sitter, heikobecker, rstephenson, kde-doc-english, gennad, fbampaloukas, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20200312/64c68434/attachment.html>