D26652: Unbreak module imports for Python2

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Jan 14 09:28:58 GMT 2020


kossebau added inline comments.

INLINE COMMENTS

> bcooksley wrote in frameworkdb.py:39
> This probably needs to be `import gvutils from kapidox.depdiagram` otherwise any calling code will need to be `kapidox.depdiagram.gvutils.<whatever>` instead of just `fvutils.<whatever>` (unless Python3 allows something special i'm not aware of)

As said no Python developer myself, but the code using the import is like this a few times below:

  for node_handle in gvutils.get_node_list(src_handle):
      node = gvutils.Node(node_handle)

so something there seems to work? Also this is the current import code added in D25632 <https://phabricator.kde.org/D25632> to have it work with Python3, so my expectation would have rather been this is correct?

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20200114/1227fb39/attachment.html>


More information about the kde-doc-english mailing list