D27201: BUG 410906 fix with added applicable handbook documentation

Ralf Habacker noreply at phabricator.kde.org
Thu Feb 6 22:21:28 GMT 2020


habacker added a comment.


  Looks good, except for the missing file and the mentioned issues, which needs an update. Since this commit affects translations, and the stable branch is locked for changes, this commit would have to go to the master branch.

INLINE COMMENTS

> settings.docbook:11
> +            <imageobject>
> +                <imagedata fileref="general-settings.png" format="PNG"/>
> +            </imageobject>

This file is missing.

> multipagedialogbase.cpp:276
>  #else
>      QUrl url = QUrl(QLatin1String("help:/umbrello/index.html"));
>      QDesktopServices::openUrl(url);

This line should also be changed: to help:/umbrello/settings.html

REPOSITORY
  R139 Umbrello

REVISION DETAIL
  https://phabricator.kde.org/D27201

To: jhayes, habacker
Cc: kde-doc-english, umbrello-devel, jhayes, vanderbilt, gennad, fbampaloukas, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20200206/281fe339/attachment.html>


More information about the kde-doc-english mailing list