D13438: Removed obsolete PackagePath role from AppletModel

Malte Veerman noreply at phabricator.kde.org
Mon Oct 21 13:56:16 BST 2019


malteveerman updated this revision to Diff 68430.
malteveerman added a comment.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.


  - Made SvgHandler handle QRC resource files.
  - Removed "PackagePath" data role from AppletModel.
  - Moved applet view from ListView to Flickable.
  - Made applet loading synchronous.
  - Fixed qrc resource url handling.
  - Restricted context flicking to vertical direction.
  
  Rebased against current master

REPOSITORY
  R181 Amarok

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13438?vs=36046&id=68430

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D13438

AFFECTED FILES
  .gitignore
  .reviewboardrc
  CMakeLists.txt
  ChangeLog
  HACKING/building_amarok2_in_home.txt
  INSTALL
  Messages.sh
  README
  cmake/modules/CMakeLists.txt
  cmake/modules/CheckQtGlib.cmake
  cmake/modules/FindFFTW3.cmake
  cmake/modules/FindGDKPixBuf.cmake
  cmake/modules/FindGooglemock.cmake
  cmake/modules/FindHUpnp.cmake
  cmake/modules/FindLibLastFm.cmake
  cmake/modules/FindLibOFA.cmake
  cmake/modules/FindMtp.cmake
  cmake/modules/FindMySQL.cmake
  cmake/modules/FindMySQLAmarok.cmake
  cmake/modules/FindQJSON.cmake
  cmake/modules/FindQtScriptQtBindings.cmake
  cmake/modules/FindTaglib-Extras.cmake
  cmake/modules/FindTaglib.cmake
  cmake/modules/bindingstest/CMakeLists.txt
  cmake/modules/bindingstest/QtScriptBindingsTest.cpp
  data/CMakeLists.txt
  data/amarok.notifyrc
  doc/CMakeLists.txt
  doc/amarok.txt
  doc/amarok_2-8_nepomukindexfolders_dialog_kde_4-11.png
  doc/amaroknepomukcollectionbrowser2-7.png
  doc/index.docbook
  images/CMakeLists.txt
  images/icons/48-actions-amarok_lyrics.png
  images/icons/48-actions-current-track-amarok.png
  images/icons/48-actions-media-album-cover-manager-amarok.png
  images/icons/48-actions-photos-amarok.png
  images/icons/48-actions-view-media-analyzer-amarok.png
  images/icons/CMakeLists.txt
  playground/src/context/applets/coverbling/CMakeLists.txt
  playground/src/context/applets/coverbling/CoverBling.h
  playground/src/context/applets/coverbling/ImageLoader.h
  playground/src/context/applets/coverbling/PhotoBrowser.h
  playground/src/context/applets/coverbling/SearchBarTextItem.h
  playground/src/context/applets/coverbling/amarok-context-applet-coverbling.desktop
  playground/src/context/applets/coverbling/pictureflow.h
  playground/src/context/applets/covergrid/AlbumItem.h
  playground/src/context/applets/covergrid/CMakeLists.txt
  playground/src/context/applets/covergrid/amarok-context-applet-covergrid.desktop
  playground/src/scripts/bbc_service/CMakeLists.txt
  playground/src/scripts/copycover/CMakeLists.txt
  playground/src/scripts/danish_streams_service/CMakeLists.txt
  playground/src/scripts/encoding_fixer/CMakeLists.txt
  playground/src/scripts/npr_service/CMakeLists.txt
  playground/src/scripts/seeqpod_service/CMakeLists.txt
  release_scripts/RELEASE_HOWTO
  shared/CMakeLists.txt
  shared/FileType.cpp
  shared/FileTypeResolver.cpp
  shared/FileTypeResolver.h
  shared/MetaReplayGain.cpp
  shared/MetaTagLib.cpp
  shared/MetaTagLib.h
  shared/TagsFromFileNameGuesser.cpp
  shared/TagsFromFileNameGuesser.h
  shared/Version.h
  shared/amarokshared_export.h
  shared/collectionscanner/Album.cpp
  shared/collectionscanner/BatchFile.cpp
  shared/collectionscanner/BatchFile.h
  shared/collectionscanner/Directory.cpp
  shared/collectionscanner/Directory.h
  shared/collectionscanner/Playlist.cpp
  shared/collectionscanner/Playlist.h
  shared/collectionscanner/Track.cpp
  shared/collectionscanner/Track.h
  shared/config.h.cmake
  shared/tag_helpers/APETagHelper.h
  shared/tag_helpers/ASFTagHelper.cpp
  shared/tag_helpers/ASFTagHelper.h
  shared/tag_helpers/ID3v2TagHelper.cpp
  shared/tag_helpers/ID3v2TagHelper.h
  shared/tag_helpers/MP4TagHelper.h
  shared/tag_helpers/StringHelper.cpp
  shared/tag_helpers/StringHelper.h
  shared/tag_helpers/TagHelper.cpp
  shared/tag_helpers/TagHelper.h
  shared/tag_helpers/VorbisCommentTagHelper.h
  src/ActionClasses.cpp
  src/ActionClasses.h
  src/AmarokMimeData.cpp
  src/AmarokMimeData.h
  src/AmarokProcess.cpp
  src/AmarokProcess.h
  src/AmarokSharedPointer.h
  src/App.cpp
  src/App.h
  src/CMakeLists.txt
  src/EngineController.cpp
  src/EngineController.h
  src/GlobalCollectionActions.cpp
  src/GlobalCollectionActions.h
  src/GlobalCurrentTrackActions.cpp
  src/GlobalCurrentTrackActions.h
  src/KNotificationBackend.cpp
  src/LastfmReadLabelCapability.h
  src/MainWindow.cpp
  src/MainWindow.h
  src/MediaDeviceCache.cpp
  src/MediaDeviceMonitor.cpp
  src/MediaDeviceMonitor.h
  src/OpmlOutline.h
  src/OpmlParser.cpp
  src/OpmlParser.h
  src/OpmlWriter.cpp
  src/OpmlWriter.h
  src/PaletteHandler.cpp
  src/PaletteHandler.h
  src/PluginManager.cpp
  src/PluginManager.h
  src/PopupDropperFactory.h
  src/QStringx.cpp
  src/QStringx.h
  src/SvgHandler.cpp
  src/SvgHandler.h
  src/SvgTinter.cpp
  src/TrayIcon.cpp
  src/TrayIcon.h
  src/aboutdialog/AnimatedBarWidget.h
  src/aboutdialog/AnimatedWidget.h
  src/aboutdialog/ExtendedAboutDialog.cpp
  src/aboutdialog/ExtendedAboutDialog.h
  src/aboutdialog/FramedLabel.h
  src/aboutdialog/OcsData.h
  src/aboutdialog/OcsPersonItem.cpp
  src/aboutdialog/OcsPersonItem.h
  src/aboutdialog/OcsPersonListWidget.cpp
  src/aboutdialog/OcsPersonListWidget.h
  src/aboutdialog/libattica-ocsclient/CMakeLists.txt
  src/aboutdialog/libattica-ocsclient/TODO
  src/aboutdialog/libattica-ocsclient/activity.cpp
  src/aboutdialog/libattica-ocsclient/activity.h
  src/aboutdialog/libattica-ocsclient/activitylistjob.cpp
  src/aboutdialog/libattica-ocsclient/activitylistjob.h
  src/aboutdialog/libattica-ocsclient/activityparser.cpp
  src/aboutdialog/libattica-ocsclient/activityparser.h
  src/aboutdialog/libattica-ocsclient/atticaclient_export.h
  src/aboutdialog/libattica-ocsclient/category.cpp
  src/aboutdialog/libattica-ocsclient/category.h
  src/aboutdialog/libattica-ocsclient/categorylistjob.cpp
  src/aboutdialog/libattica-ocsclient/categorylistjob.h
  src/aboutdialog/libattica-ocsclient/categoryparser.cpp
  src/aboutdialog/libattica-ocsclient/categoryparser.h
  src/aboutdialog/libattica-ocsclient/content.cpp
  src/aboutdialog/libattica-ocsclient/content.h
  src/aboutdialog/libattica-ocsclient/contentjob.cpp
  src/aboutdialog/libattica-ocsclient/contentjob.h
  src/aboutdialog/libattica-ocsclient/contentlistjob.cpp
  src/aboutdialog/libattica-ocsclient/contentlistjob.h
  src/aboutdialog/libattica-ocsclient/contentparser.cpp
  src/aboutdialog/libattica-ocsclient/contentparser.h
  src/aboutdialog/libattica-ocsclient/event.cpp
  src/aboutdialog/libattica-ocsclient/event.h
  src/aboutdialog/libattica-ocsclient/eventjob.cpp
  src/aboutdialog/libattica-ocsclient/eventjob.h
  src/aboutdialog/libattica-ocsclient/eventlistjob.cpp
  src/aboutdialog/libattica-ocsclient/eventlistjob.h
  src/aboutdialog/libattica-ocsclient/eventparser.cpp
  src/aboutdialog/libattica-ocsclient/eventparser.h
  src/aboutdialog/libattica-ocsclient/folder.cpp
  src/aboutdialog/libattica-ocsclient/folder.h
  src/aboutdialog/libattica-ocsclient/folderlistjob.cpp
  src/aboutdialog/libattica-ocsclient/folderlistjob.h
  src/aboutdialog/libattica-ocsclient/folderparser.cpp
  src/aboutdialog/libattica-ocsclient/folderparser.h
  src/aboutdialog/libattica-ocsclient/knowledgebase.cpp
  src/aboutdialog/libattica-ocsclient/knowledgebase.h
  src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp
  src/aboutdialog/libattica-ocsclient/knowledgebasejob.h
  src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp
  src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.h
  src/aboutdialog/libattica-ocsclient/knowledgebaseparser.cpp
  src/aboutdialog/libattica-ocsclient/knowledgebaseparser.h
  src/aboutdialog/libattica-ocsclient/message.cpp
  src/aboutdialog/libattica-ocsclient/message.h
  src/aboutdialog/libattica-ocsclient/messagelistjob.cpp
  src/aboutdialog/libattica-ocsclient/messagelistjob.h
  src/aboutdialog/libattica-ocsclient/messageparser.cpp
  src/aboutdialog/libattica-ocsclient/messageparser.h
  src/aboutdialog/libattica-ocsclient/person.cpp
  src/aboutdialog/libattica-ocsclient/person.h
  src/aboutdialog/libattica-ocsclient/personjob.cpp
  src/aboutdialog/libattica-ocsclient/personjob.h
  src/aboutdialog/libattica-ocsclient/personlistjob.cpp
  src/aboutdialog/libattica-ocsclient/personlistjob.h
  src/aboutdialog/libattica-ocsclient/personparser.cpp
  src/aboutdialog/libattica-ocsclient/personparser.h
  src/aboutdialog/libattica-ocsclient/postjob.cpp
  src/aboutdialog/libattica-ocsclient/postjob.h
  src/aboutdialog/libattica-ocsclient/provider.cpp
  src/aboutdialog/libattica-ocsclient/provider.h
  src/aboutdialog/libattica-ocsclient/providerinitjob.cpp
  src/aboutdialog/libattica-ocsclient/providerinitjob.h
  src/amarok-contextapplet.desktop
  src/amarok-play-audiocd.desktop
  src/amarok-plugin.desktop
  src/amarok_addaspodcast.desktop
  src/amarok_append.desktop
  src/amarok_export.h
  src/amarokurls/AmarokUrl.cpp
  src/amarokurls/AmarokUrl.h
  src/amarokurls/AmarokUrlGenerator.h
  src/amarokurls/AmarokUrlHandler.cpp
  src/amarokurls/AmarokUrlHandler.h
  src/amarokurls/AmarokUrlRunnerBase.h
  src/amarokurls/BookmarkCurrentButton.cpp
  src/amarokurls/BookmarkCurrentButton.h
  src/amarokurls/BookmarkGroup.cpp
  src/amarokurls/BookmarkGroup.h
  src/amarokurls/BookmarkManager.cpp
  src/amarokurls/BookmarkManager.h
  src/amarokurls/BookmarkManagerWidget.cpp
  src/amarokurls/BookmarkManagerWidget.h
  src/amarokurls/BookmarkMetaActions.cpp
  src/amarokurls/BookmarkMetaActions.h
  src/amarokurls/BookmarkModel.cpp
  src/amarokurls/BookmarkModel.h
  src/amarokurls/BookmarkTreeView.cpp
  src/amarokurls/BookmarkTreeView.h
  src/amarokurls/ContextUrlGenerator.cpp
  src/amarokurls/ContextUrlGenerator.h
  src/amarokurls/ContextUrlRunner.cpp
  src/amarokurls/ContextUrlRunner.h
  src/amarokurls/NavigationUrlGenerator.cpp
  src/amarokurls/NavigationUrlGenerator.h
  src/amarokurls/NavigationUrlRunner.cpp
  src/amarokurls/NavigationUrlRunner.h
  src/amarokurls/PlayUrlGenerator.cpp
  src/amarokurls/PlayUrlGenerator.h
  src/amarokurls/PlayUrlRunner.cpp
  src/amarokurls/PlayUrlRunner.h
  src/browsers/BrowserBreadcrumbItem.cpp
  src/browsers/BrowserBreadcrumbItem.h
  src/browsers/BrowserBreadcrumbWidget.cpp
  src/browsers/BrowserBreadcrumbWidget.h
  src/browsers/BrowserCategory.cpp
  src/browsers/BrowserCategory.h
  src/browsers/BrowserCategoryList.cpp
  src/browsers/BrowserCategoryList.h
  src/browsers/BrowserCategoryListDelegate.h
  (1410 more files...)

To: malteveerman, #amarok
Cc: kde-doc-english, amarok-devel, #amarok, gennad, fbampaloukas, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20191021/6f9e2ae0/attachment.html>


More information about the kde-doc-english mailing list