D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small

Nathaniel Graham noreply at phabricator.kde.org
Fri May 24 16:07:17 BST 2019


ngraham added a comment.


  Thanks, just one last little thing...

INLINE COMMENTS

> thumbnailprovidertest.cpp:226
>          QCOMPARE(spy.count(), 1);
> -        expectedThumbnail = createColoredImage(256, 128, QColor(254, 0, 0));
> +        if(GwenviewConfig::deleteThumbnailCacheOnExit()) {
> +            expectedThumbnail = createColoredImage(128, 64, Qt::white);

space after the `if`

REVISION DETAIL
  https://phabricator.kde.org/D21330

To: tommo, #gwenview
Cc: yurchor, kde-doc-english, ngraham, #gwenview, tommo, gennad, clintmoyer, tdarboux, huoni, muhlenpfordt, rkflx, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20190524/a4433302/attachment.html>


More information about the kde-doc-english mailing list