[plasma-desktop] /: Call KRunner KRunner

[Nate Graham]

Git commit d0c8fe93982e86b89bcd416830fab33d091001a7 by Nate Graham.
Committed on 22/05/2019 at 18:19.
Pushed by ngraham into branch 'master'.

Call KRunner KRunner

Summary:
Plasma uses inconsistent terminology to refer to KRunner, calling it "Run Command" in
Kicker/Kickoff/etc, but "Plasma Search" in System Settings. For reasons explained in
{T10966} neither term is ideal, and the inconsistency is bad too.

This patch unifies on "Show KRunner" for the action and "KRunner" for the KCM name,
transforming it into a recognizable brand name like Apple's Spotlight.

This patch also makes the icons consistent and adjusts some strings to more clearly
indicate what KRunner is and does.

Test Plan:
{F6842587}

{F6842586}

Reviewers: #vdg, #plasma, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, plasma-devel, kde-doc-english

Tags: #plasma, #documentation

Maniphest Tasks: T10966

Differential Revision: https://phabricator.kde.org/D21343

M  +3    -3    applets/kicker/plugin/computermodel.cpp
M  +1    -1    design/containmentactions
M  +1    -1    doc/plasma-desktop/index.docbook
M  +1    -1    kcms/runners/kcm.cpp
M  +1    -1    kcms/runners/kcm_plasmasearch.desktop

https://commits.kde.org/plasma-desktop/d0c8fe93982e86b89bcd416830fab33d091001a7

diff --git a/applets/kicker/plugin/computermodel.cpp b/applets/kicker/plugin/computermodel.cpp
index 4e6272c2..7227174d 100644
--- a/applets/kicker/plugin/computermodel.cpp
+++ b/applets/kicker/plugin/computermodel.cpp
@@ -101,11 +101,11 @@ QVariant RunCommandModel::data(const QModelIndex &index, int role) const
     }
 
     if (role == Qt::DisplayRole) {
-        return i18n("Run Command...");
+        return i18n("Show KRunner");
     } else if (role == Qt::DecorationRole) {
-        return QIcon::fromTheme(QStringLiteral("system-run"));
+        return QIcon::fromTheme(QStringLiteral("plasma-search"));
     } else if (role == Kicker::DescriptionRole) {
-        return i18n("Run a command or a search query");
+        return i18n("Search, calculate, or run a command");
     } else if (role == Kicker::GroupRole) {
         return i18n("Applications");
     }
diff --git a/design/containmentactions b/design/containmentactions
index c1c201d1..492e2dad 100644
--- a/design/containmentactions
+++ b/design/containmentactions
@@ -63,7 +63,7 @@ Containment Interface
 The Containment class supports loading and using containmentactions plugins.
 Subclasses need do nothing to get this support. If a subclass has extra actions it wants in the
 contextmenu, it can provide them in contextualActions() the same as before - but there's no longer
-any need to return standard actions like "add widgets" and "run command".
+any need to return standard actions like "add widgets" and "show krunner".
 
 ContextActions plugins to use are set using the setContainmentActions(const QString &trigger, const QString &pluginName)
 method. an empty string removes any plugin set for the given trigger.
diff --git a/doc/plasma-desktop/index.docbook b/doc/plasma-desktop/index.docbook
index 9b10bde8..64691188 100644
--- a/doc/plasma-desktop/index.docbook
+++ b/doc/plasma-desktop/index.docbook
@@ -548,7 +548,7 @@ navigate through the matches using the tab and arrow keys.
 </screenshot>
 
 <para>Use the <inlinemediaobject><imageobject><imagedata fileref="krunner-configure.png" format="PNG"/>
-</imageobject></inlinemediaobject> button to open the <guilabel>Plasma Search</guilabel> &systemsettings; 
+</imageobject></inlinemediaobject> button to open the <guilabel>KRunner</guilabel> &systemsettings;
 module and configure where and what to search for in &krunner;
 </para>
 
diff --git a/kcms/runners/kcm.cpp b/kcms/runners/kcm.cpp
index 555cd65c..3ce5f4f3 100644
--- a/kcms/runners/kcm.cpp
+++ b/kcms/runners/kcm.cpp
@@ -56,7 +56,7 @@ SearchConfigModule::SearchConfigModule(QWidget* parent, const QVariantList& args
 
     QHBoxLayout *headerLayout = new QHBoxLayout(this);
 
-    QLabel *label = new QLabel(i18n("Select the search plugins:"));
+    QLabel *label = new QLabel(i18n("Enable or disable KRunner plugins:"));
 
     QPushButton *clearHistoryButton = new QPushButton(i18n("Clear History"));
     clearHistoryButton->setIcon(QIcon::fromTheme(isRightToLeft() ? QStringLiteral("edit-clear-locationbar-ltr")
diff --git a/kcms/runners/kcm_plasmasearch.desktop b/kcms/runners/kcm_plasmasearch.desktop
index 96b7000c..edb4466b 100644
--- a/kcms/runners/kcm_plasmasearch.desktop
+++ b/kcms/runners/kcm_plasmasearch.desktop
@@ -10,7 +10,7 @@ X-KDE-ParentApp=kcontrol
 X-KDE-System-Settings-Parent-Category=search
 X-KDE-Weight=20
 
-Name=Plasma Search
+Name=KRunner
 Name[ar]=بحث بلازما
 Name[bs]=Plazma pretraga
 Name[ca]=Cerca de Plasma