D21156: Fix browse mode not disabled after Ctrl is released
Simone Gaiarin
noreply at phabricator.kde.org
Wed Jun 26 07:16:53 BST 2019
simgunz added a comment.
In D21156#486717 <https://phabricator.kde.org/D21156#486717>, @aacid wrote:
> If you're not using arc you should have included the "Differential Revision" line in the commit so it would close automatically as stated in https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
>
> I'll close this manually for you :)
In the phabricator guide it is suggested to push manually when the target branch in not master:
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
Wouldn't make more sense to do `arc land --onto 5.3` (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.
Final question: for discussing things like this, regarding the https://community.kde.org guides, what is the most appropriate place? Opening a discussion on the Wiki page? Or is it therea bugs.kde.org section for this (I could not find an obvious one).
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D21156
To: simgunz, #kdevelop, rjvbb, mwolff
Cc: aacid, kde-doc-english, mwolff, rjvbb, kdevelop-devel, hmitonneau, christiant, gennad, fbampaloukas, glebaccon, domson, antismap, iodelay, alexeymin, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20190626/813b2a1f/attachment.html>
More information about the kde-doc-english
mailing list