D19291: WIP: Rewrite front-end of docs.kde.org (alternative to D17936)

Carl Schwan noreply at phabricator.kde.org
Sun Feb 24 22:22:35 GMT 2019


ognarb added inline comments.

INLINE COMMENTS

> initialize.inc.php:12
>  {
> -	/* keep only the first block of proper characters */
> -	$sane_pattern = "/^([[:alnum:]-_\.]+)/";
> -	$input_matched = preg_match($sane_pattern, htmlentities($input_string), $matches);
> -	if ($input_matched) {
> -		return $matches[1];
> -	} else {
> -		return "";
> -	}
> +    if (is_null($input_string)) {
> +        return "";

The original code didn't work for me with a recent php version

REPOSITORY
  R184 Documentation Website (docs.kde.org)

REVISION DETAIL
  https://phabricator.kde.org/D19291

To: ognarb, ltoscano, #documentation
Cc: kde-doc-english, gennad, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20190224/0f200b0e/attachment.html>


More information about the kde-doc-english mailing list