D26291: rework of keyboard widgets focus

[Davide Gianforte]

gengisdave created this revision.
gengisdave added reviewers: Krusader, yurchor.
gengisdave added a project: Krusader.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.
gengisdave requested review of this revision.

REVISION SUMMARY
  In Krusader you can move between widgets both with two configurable shortcuts "Focus up/down" (default : CTRL+SHIFT+UP/DOWN) and with an hardcoded CTRL+UP/DOWN, but neither can move through all the widgets.
  
  This patch drops the hardcoded version in favor of the configurable one letting all widgets to be focused in sequence, all the unneeded code is removed.
  
  The documentation is changed with the new shortcuts.
  
  FIXED: [ 414831 ] cant focus embedded terminal with ctrl+down
  BUG: 414831

TEST PLAN
  With every or part of the widgets active, CTRL+SHIFT+UP/DOWN (or anything else configured as Focus up/down), must move between the widgets in the following order (from top to bottom):
  
  - Location Bar (edit mode on focus in, navigate mode on focus out)
  - File View
  - Sidebar (it is considered always beneath the file view, unregarding its real position)
  - Embedded emulator
  - Command line
  
  Moreover, CTRL+UP/DOWN should not change widgets focus

REPOSITORY
  R167 Krusader

REVISION DETAIL
  https://phabricator.kde.org/D26291

AFFECTED FILES
  doc/user-interface.docbook
  krusader/GUI/kcmdline.cpp
  krusader/GUI/terminaldock.cpp
  krusader/Panel/PanelView/krview.cpp
  krusader/Panel/listpanel.cpp
  krusader/krusaderview.cpp

To: gengisdave, #krusader, yurchor
Cc: yurchor, kde-doc-english, #krusader, gennad, fbampaloukas, nmel, mjanczara, miroslavm, skadinna, janlepper, abika, martinkostolny, asensi, gengisdave, andreaska
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20191230/667d3b76/attachment.html>