[kdesrc-build] /: Use HTTPS instead of Git protocol as default git transport.

Michael Pyne null at kde.org
Sun Sep 23 01:22:13 BST 2018


Git commit 2c09ca0d8bc469d9860fc293b3e1eae2814dd4cb by Michael Pyne, on behalf of Johan Ouwerkerk.
Committed on 23/09/2018 at 00:21.
Pushed by mpyne into branch 'master'.

Use HTTPS instead of Git protocol as default git transport.

With this change, users of kdesrc-build have better protection from man
in the middle attacks on source code transfers by default without having
to switch to SSH-tunneled Git protocol.

BUG:398858
FIXED-IN:18.09

M  +1    -1    README
M  +1    -1    doc/index.docbook
M  +1    -1    kf5-kdepim-build-include
M  +1    -1    modules/ksb/BuildException.pm
M  +2    -2    modules/ksb/Updater/Git.pm

https://commits.kde.org/kdesrc-build/2c09ca0d8bc469d9860fc293b3e1eae2814dd4cb

diff --git a/README b/README
index 40a8bba..bad1446 100644
--- a/README
+++ b/README
@@ -12,7 +12,7 @@
 
       $ mkdir -p ~/kdesrc
       $ cd ~/kdesrc
-      $ git clone git://anongit.kde.org/kdesrc-build
+      $ git clone https://anongit.kde.org/kdesrc-build
       $ cd kdesrc-build # kdesrc-build is in this directory
 
 2. Setup:
diff --git a/doc/index.docbook b/doc/index.docbook
index f1ccd08..64dc4c7 100644
--- a/doc/index.docbook
+++ b/doc/index.docbook
@@ -374,7 +374,7 @@ source repository and then periodically updating it.</para>
 
 <para>You can obtain &kdesrc-build; from its source repository by running:</para>
 <programlisting>
-<prompt>$ </prompt><userinput><command>git <option>clone</option> <option>git://anongit.kde.org/kdesrc-build</option> <option><filename class="directory"><replaceable>~/kdesrc-build</replaceable></filename></option></command></userinput>
+<prompt>$ </prompt><userinput><command>git <option>clone</option> <option>https://anongit.kde.org/kdesrc-build</option> <option><filename class="directory"><replaceable>~/kdesrc-build</replaceable></filename></option></command></userinput>
 </programlisting>
 
 <para>Replace <option><replaceable>~/kdesrc-build</replaceable></option> with
diff --git a/kf5-kdepim-build-include b/kf5-kdepim-build-include
index 12ba52d..5fac49d 100644
--- a/kf5-kdepim-build-include
+++ b/kf5-kdepim-build-include
@@ -38,7 +38,7 @@ end module-set
 module libkolab
 # FIXME: upstream is unresponsive and doesn't compile anymore
 #    repository https://git.kolab.org/diffusion/LK/libkolab.git
-    repository git://anongit.kde.org/scratch/vkrause/libkolab
+    repository https://anongit.kde.org/scratch/vkrause/libkolab
     branch libkolab-1.0
 end module
 
diff --git a/modules/ksb/BuildException.pm b/modules/ksb/BuildException.pm
index a820405..f55dd9a 100644
--- a/modules/ksb/BuildException.pm
+++ b/modules/ksb/BuildException.pm
@@ -78,7 +78,7 @@ package ksb::BuildException::Config 0.10 {
             $result = <<"EOF";
 The y[git-repository-base] option requires a repository name and URL.
 
-e.g. git-repository base y[b[kde] g[b[git://anongit.kde.org/]
+e.g. git-repository base y[b[kde] g[b[https://anongit.kde.org/]
 
 Use this in a "module-set" group:
 
diff --git a/modules/ksb/Updater/Git.pm b/modules/ksb/Updater/Git.pm
index b1919ba..72bd294 100644
--- a/modules/ksb/Updater/Git.pm
+++ b/modules/ksb/Updater/Git.pm
@@ -774,7 +774,7 @@ sub hasRemote
 sub verifyGitConfig
 {
     my $configOutput =
-        qx'git config --global --get url.git://anongit.kde.org/.insteadOf kde:';
+        qx'git config --global --get url.https://anongit.kde.org/.insteadOf kde:';
 
     # 0 means no error, 1 means no such section exists -- which is OK
     if ((my $errNum = $? >> 8) >= 2) {
@@ -799,7 +799,7 @@ sub verifyGitConfig
     if ($configOutput !~ /^kde:\s*$/) {
         whisper ("\tAdding git download kde: alias");
         my $result = safe_system(
-            qw(git config --global --add url.git://anongit.kde.org/.insteadOf kde:)
+            qw(git config --global --add url.https://anongit.kde.org/.insteadOf kde:)
         ) >> 8;
         return 0 if $result != 0;
     }



More information about the kde-doc-english mailing list