D15205: Support setting font color for typewriter annotation
Tobias Deiminger
noreply at phabricator.kde.org
Wed Oct 3 10:09:35 BST 2018
tobiasdeiminger added a comment.
In D15205#335752 <https://phabricator.kde.org/D15205#335752>, @sander wrote:
> I now actually tested and it works very nicely. I'll approve the diff, because I don't have a strong opinion on the whitespace issue.
Thanks for reviewing.
> I'd be nice if the color of the 'T' icon could show the current text color (like the Freehand Line icon does it). Currently it is always black. But that is a separate issue, right?
Icon color already worked in Dileeps patch, so it's a regression introduced by me. I'll fix it before pushing.
REPOSITORY
R223 Okular
BRANCH
typewriter_td_fontcolor (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15205
To: tobiasdeiminger, sander
Cc: kde-doc-english, sander, okular-devel, ngraham, skadinna, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20181003/9f98be34/attachment.html>
More information about the kde-doc-english
mailing list