D15205: Support setting font color for typewriter annotation

[Tobias Deiminger]

tobiasdeiminger added inline comments.

INLINE COMMENTS

> sander wrote in annotationwidgets.cpp:315
> I think these whitespace changes should be in a separate patch (if they are desired at all).

Desired, because I did them wrong in the first typewriter commit. To be honest, I'd find an extra commit saying "3 whitespace changes" more annoying.

How about one single big style cleanup commit for the whole project (pro: helps to spare us periodic discussion about whitespaces for a while, con: remember to tell your tool to ignore whitespace changes when searching history for functional changes).

> sander wrote in annotationwidgets.cpp:321
> I think this whitespace change should be in a separate patch (if it is desired at all).

Same as above.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15205

To: tobiasdeiminger
Cc: kde-doc-english, sander, okular-devel, ngraham, skadinna, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20181002/6f907258/attachment.html>