[khelpcenter] [Bug 399274] Duplicated menu items in khelpcenter

Luigi Toscano bugzilla_noreply at kde.org
Mon Nov 19 00:21:07 GMT 2018


https://bugs.kde.org/show_bug.cgi?id=399274

Luigi Toscano <luigi.toscano at tiscali.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/khe
                   |                            |lpcenter/3e5549ebe181560d92
                   |                            |e803cccfde58ebc3573625
             Status|REPORTED                    |RESOLVED

--- Comment #1 from Luigi Toscano <luigi.toscano at tiscali.it> ---
Git commit 3e5549ebe181560d92e803cccfde58ebc3573625 by Luigi Toscano, on behalf
of Pavel Mars.
Committed on 19/11/2018 at 00:20.
Pushed by ltoscano into branch 'Applications/18.12'.

Remove duplicate submenus.

Summary:
Signed-off-by: Pavel Mars <mars at basealt.ru>

Remove duplicate submenus.

On the left side of the khelpcenter window is the content ("Contents").
If you open the item "Application Manuals" -> "System" -> "Info Center", the
item "Info Center" will generate a tree of additional menu items.

If you open the menu item "KInfoCenter Modules" in the same content and then
open the menu items that appear (for example, "Device Viewer", "Memory",
"OpenGL" or any other item), the same additional menu item tree will be
generated.

This change removes duplication of generated trees.

This is achieved by registering the URLs of the elements of the content tree in
a separate container and checking the URL to be opened: if the base address
from the URL is registered, then we request the generation of the menu tree
from the registered element of the tree, but not from the current one.

Reviewers: yurchor, ltoscano

Reviewed By: yurchor, ltoscano

Subscribers: ltoscano, kde-doc-english

Tags: #documentation

Differential Revision: https://phabricator.kde.org/D16308

M  +35   -1    navigatorappitem.cpp
M  +3    -0    navigatorappitem.h

https://commits.kde.org/khelpcenter/3e5549ebe181560d92e803cccfde58ebc3573625

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the kde-doc-english mailing list