D11731: Fix disappearing searchbar when bookmark menu is opened for another tab.
Rade Deguerre
noreply at phabricator.kde.org
Thu Mar 29 19:10:43 UTC 2018
rade added a comment.
In D11731#236223 <https://phabricator.kde.org/D11731#236223>, @martinkostolny wrote:
> Sorry about that, I should have waited a bit longer. So how about this?
>
> // removing action from previous menu is necessary
> // otherwise it wouldn't be displayed in currently populating menu
> if (_mainBookmarkPopup) {
> _mainBookmarkPopup->removeAction(_quickSearchAction);
> }
>
Looks good, although I think it should be "won't" not "wouldn't" as it is an action that will not happen in the future not an action that has not happened in the past.
REPOSITORY
R167 Krusader
REVISION DETAIL
https://phabricator.kde.org/D11731
To: martinkostolny, #krusader, rade, nmel
Cc: kde-doc-english, nmel, mjanczara, miroslavm, janlepper, abika, martinkostolny, asensi, gengisdave, andreaska
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20180329/699b25c9/attachment.html>
More information about the kde-doc-english
mailing list