D11495: Align slideshow terminology to MPRIS behaviour

[Henrik Fehlauer]

rkflx created this revision.
rkflx added reviewers: Gwenview, kossebau.
Restricted Application added a subscriber: kde-doc-english.
rkflx requested review of this revision.

REVISION SUMMARY
  9631043c110d <https://phabricator.kde.org/R260:9631043c110dba485db5deea120e8b13116c3ac7> introduced MPRIS support to Gwenview. Common MPRIS
  controllers often only provide "Pause" in the main interface, with
  "Stop" being non-existent or hidden. Therefore "holding" the slideshow
  was mapped to "Pause". "Play" either "Resumes" automatically advancing
  to the next image, or in non-fullscreen mode switches to fullscreen and
  starts playback. Conversely, "Stop" ends playback and exits from
  fullscreen.
  
  To keep consistency, we change the tooltip text of the fullscreen button
  controlling the playback to "Pause". In addition, the internal `enum` is
  adapted accordingly to avoid confusing developers.
  
  Note that the icon on the button still shows a "Pause" symbol as before
  the patch.
  
  Ref T8222 <https://phabricator.kde.org/T8222>

TEST PLAN
  Start Gwenview normally, with `-f` and with `-s`, and observe the
  tooltip of the playback button in the top fullscreen toolbar as well as
  the button text in non-fullscreen mode (use Configure Toolbars to
  add it) make sense in every situation.

REPOSITORY
  R260 Gwenview

BRANCH
  mpris-pause-renaming (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11495

AFFECTED FILES
  app/mainwindow.cpp
  doc/index.docbook
  lib/mpris2/mprismediaplayer2player.cpp
  lib/slideshow.cpp
  lib/slideshow.h

To: rkflx, #gwenview, kossebau
Cc: kde-doc-english
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20180319/5ac9ddc9/attachment.html>