D17626: Print preview for KmPlot
Yuri Chornoivan
noreply at phabricator.kde.org
Mon Dec 24 16:33:00 GMT 2018
yurchor marked 2 inline comments as done.
yurchor added inline comments.
INLINE COMMENTS
> tcanabrava wrote in maindlg.cpp:703-704
> If you are creating them here to delete them in the end of the function, why don't you create them on the stack?
The same pattern can be found above.
Just for other possible reviewers, the discussions on this topic can be found by the following addresses
https://blogs.kde.org/node/3919
https://phabricator.kde.org/D7285
https://phabricator.kde.org/D17697
It seems that this is a questionable decision but it might be of some sense. Thanks in advance for your opinions.
REPOSITORY
R334 KmPlot
REVISION DETAIL
https://phabricator.kde.org/D17626
To: yurchor, #kde_edu, tcanabrava
Cc: tcanabrava, kde-doc-english, kde-edu, skadinna, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20181224/e1c7878d/attachment.html>
More information about the kde-doc-english
mailing list