[lokalize] /: Bump lokalize version to 18.12

Simon Depiets null at kde.org
Wed Dec 5 11:22:40 GMT 2018


Git commit e0d08228fa4bccc06cb0f75ecbdacfef614921c3 by Simon Depiets.
Committed on 05/12/2018 at 11:18.
Pushed by sdepiets into branch 'master'.

Bump lokalize version to 18.12

Summary:
I'm creating this revision to open a discussion on the lokalize version convention.

It is currently 2.0 both in the application and in the files generated (and has been like that since 2014), having it track the kde apps version would make bugs identification easier.

The only drawback is that the .po commits would be a bit more verbose if some people do not have the latest version.

Reviewers: #localization

Subscribers: kde-doc-english, ltoscano, yurchor

Tags: #localization, #documentation

Differential Revision: https://phabricator.kde.org/D17364

M  +9    -2    CMakeLists.txt
M  +1    -1    doc/index.docbook
M  +3    -0    src/CMakeLists.txt
R  +1    -1    src/version.h.cmake [from: src/version.h - 095% similarity]

https://commits.kde.org/lokalize/e0d08228fa4bccc06cb0f75ecbdacfef614921c3

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fa61f35..c51d50a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,6 +1,13 @@
-cmake_minimum_required(VERSION 2.8.12)
+# Lokalize project
+cmake_minimum_required(VERSION 3.0)
 
-project(lokalize)
+# KDE Application Version, managed by release script
+set (KDE_APPLICATIONS_VERSION_MAJOR "19")
+set (KDE_APPLICATIONS_VERSION_MINOR "03")
+set (KDE_APPLICATIONS_VERSION_MICRO "70")
+set (KDE_APPLICATIONS_VERSION "${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}")
+
+project(lokalize VERSION ${KDE_APPLICATIONS_VERSION})
 
 set(QT_MIN_VERSION "5.5.0")
 set(KF5_MIN_VERSION "5.14.0")
diff --git a/doc/index.docbook b/doc/index.docbook
index 2b59f28..49071e5 100644
--- a/doc/index.docbook
+++ b/doc/index.docbook
@@ -27,7 +27,7 @@
 <legalnotice>&FDLNotice;</legalnotice>
 
 <date>2018-10-14</date>
-<releaseinfo>2.0 (Applications 18.12)</releaseinfo>
+<releaseinfo>Applications 18.12</releaseinfo>
 
 <abstract>
 <para>
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index ed02c24..4a1fa81 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -31,6 +31,9 @@ include_directories(
     ${CMAKE_CURRENT_BINARY_DIR}
 )
 
+configure_file(version.h.cmake
+    ${CMAKE_CURRENT_BINARY_DIR}/version.h)
+
 set(lokalize_SRCS
     main.cpp
     lokalizemainwindow.cpp
diff --git a/src/version.h b/src/version.h.cmake
similarity index 95%
rename from src/version.h
rename to src/version.h.cmake
index a5ee0b3..ddcc740 100644
--- a/src/version.h
+++ b/src/version.h.cmake
@@ -23,5 +23,5 @@
 **************************************************************************** */
 
 #ifndef LOKALIZE_VERSION
-#define LOKALIZE_VERSION "2.0"
+#define LOKALIZE_VERSION "${KDE_APPLICATIONS_VERSION}"
 #endif



More information about the kde-doc-english mailing list