[frameworks-kdoctools] [Bug 377573] cmake script regex problem

Nicolás Alvarez bugzilla_noreply at kde.org
Sat Sep 2 22:55:46 UTC 2017


https://bugs.kde.org/show_bug.cgi?id=377573

Nicolás Alvarez <nicolas.alvarez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kdo
                   |                            |ctools/68b787bd79120bb72293
                   |                            |80165f8f94a64614ae4b

--- Comment #2 from Nicolás Alvarez <nicolas.alvarez at gmail.com> ---
Git commit 68b787bd79120bb7229380165f8f94a64614ae4b by Nicolás Alvarez.
Committed on 02/09/2017 at 22:55.
Pushed by nalvarez into branch 'master'.

CMake: Fix target name shortening when build dir has special characters

The DocTools CMake macros generate a target name based on the path of the
file to generate. Since the target name was too long sometimes, especially
on Windows (which has path length limits), in a624463c62 I added a regex
replacement to strip the build directory from the path before transforming
it to a target name.

However, this was causing an error if the build directory had any regex
special characters, such as '+'.

I'm now using file(RELATIVE_PATH) instead of a regular expression to strip
off the build dir root, which should be more reliable and work for any
characters.

M  +1    -1    KF5DocToolsMacros.cmake

https://commits.kde.org/kdoctools/68b787bd79120bb7229380165f8f94a64614ae4b

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the kde-doc-english mailing list