Review Request 129866: Update kajongg docbook to kf5

Wolfgang Rohdewald wolfgang at rohdewald.de
Sun Jan 22 13:49:12 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129866/#review102167
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for proof-reading!


doc/index.docbook (line 50)
<https://git.reviewboard.kde.org/r/129866/#comment68246>

    2017-01-20



doc/index.docbook (line 423)
<https://git.reviewboard.kde.org/r/129866/#comment68247>

    view-scoring must be very old, it does not even exist in KDE 4/13 anymore. I removed it.



doc/index.docbook (line 482)
<https://git.reviewboard.kde.org/r/129866/#comment68248>

    is back again, was a bug



doc/index.docbook (line 526)
<https://git.reviewboard.kde.org/r/129866/#comment68249>

    is back, same problem as with view-chat



doc/index.docbook (line 543)
<https://git.reviewboard.kde.org/r/129866/#comment68250>

    Was not yet implemented again (some months ago, KDE4 python bindings still worked, so fullscreen worked too, but now the python bindings are broken and unmaintained, so I had to rewrite all that stuff from scratch in python)



doc/index.docbook (line 675)
<https://git.reviewboard.kde.org/r/129866/#comment68252>

    fixed



doc/index.docbook (line 676)
<https://git.reviewboard.kde.org/r/129866/#comment68253>

    fixed


- Wolfgang Rohdewald


On Jan. 21, 2017, 9:44 nachm., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129866/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2017, 9:44 nachm.)
> 
> 
> Review request for Documentation, KDE Games and Wolfgang Rohdewald.
> 
> 
> Repository: kajongg
> 
> 
> Description
> -------
> 
> remove entities kappname, kappversion, package. not used in kf5
> bump date + use scheme from templates.docbook from kdoctools for releaseinfo
> 
> @Wolfgang, please check:
> add some FIXMEs for menuitems I do not have in my master build, local issue?
> 
> Line 675-676 has paths which seem to be wrong, see FIXMEs
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook 84e005c 
> 
> Diff: https://git.reviewboard.kde.org/r/129866/diff/
> 
> 
> Testing
> -------
> 
> checkXML5 index.docbook
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20170122/1e8b7079/attachment.html>


More information about the kde-doc-english mailing list