Review Request 129808: move kcron kcm docbook to subdir kcontrol, proofread + update date/releaseinfo

[Luigi Toscano]

> On Jan. 12, 2017, 3:25 p.m., Luigi Toscano wrote:
> > kcontrol or kcontrol5?
> 
> Burkhard Lück wrote:
>     KCron switched to kf5 with 15.04, i.e two years ago
>     debian stable has kcron 4.14 (kde4 based), but no kf5 afaik
>     therefore I doubt coinstallable is an issue here?
>     
>     Naming scheme is not very consistent in trunk:
>     ~/src/l10n-kf5/documentation$ ls -d */kcontrol*
>     applications/kcontrol5  extragear-base/kcontrol  frameworks/kcontrol5  kdegraphics/kcontrol  kdemultimedia/kcontrol  kdeutils/kcontrol  kde-workspace/kcontrol  kde-workspace/kcontrol5
>     
>     Should I use kcontrol5 subdir name for kcron to avoid any possible trouble/issues re coinstallable?

That's a good question. Consistency would be a good thing and maybe a bit useful when we will move to KF6, but I'm not holding the review for this.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129808/#review101963
-----------------------------------------------------------


On Jan. 12, 2017, 3:22 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129808/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 3:22 p.m.)
> 
> 
> Review request for Documentation.
> 
> 
> Repository: kcron
> 
> 
> Description
> -------
> 
> the kcron kcm docbook was installed to subdir kcontrol/kcron, but the translated docbooks to subdir kcron, 
> therefore the language docbooks are not found in kf5 khelpcenter and only the english docbook is displayed
> 
> To fix this:
> move kcron kcm docbook to subdir kcontrol, consistent to dir layout in kde4 and as dir layout kdeutils/kdf
> proofread + update date/releaseinfo
> 
> When this RR is committed/closed we need
> 
> 1) this patch 
> $ svn diff l10n-kf5/scripts/documentation_paths 
> Index: l10n-kf5/scripts/documentation_paths
> ===================================================================
> --- l10n-kf5/scripts/documentation_paths        (revision 1479927)
> +++ l10n-kf5/scripts/documentation_paths        (working copy)
> @@ -184,7 +184,7 @@
>  entry umbrello git://anongit.kde.org/umbrello.git frameworks:doc
>  
>  module kdeadmin
> -entry kcron git://anongit.kde.org/kcron.git HEAD:doc
> +entry kcontrol/kcron git://anongit.kde.org/kcron.git HEAD:doc/kcontrol
>  entry ksystemlog git://anongit.kde.org/ksystemlog.git HEAD:doc
>  
>  module kdeutils
> 
> 2) move docmessages/kdeadmin/kcron.po docmessages/kdeadmin/kcontrol_kcron.po in process_orphans.sh
> 
> 
> Diffs
> -----
> 
>   doc/CMakeLists.txt 28c7292 
>   doc/index.docbook  
>   doc/kcontrol/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/index.docbook 38dfe72 
>   doc/kcronstart.png  
>   doc/newtask.png  
>   doc/newvariable.png  
> 
> Diff: https://git.reviewboard.kde.org/r/129808/diff/
> 
> 
> Testing
> -------
> 
> kcron build + installed
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20170112/9e28ace4/attachment.html>