Review Request 129579: update fundamentals docbook
Luigi Toscano
luigi.toscano at tiscali.it
Wed Nov 30 20:50:17 UTC 2016
> On Nov. 28, 2016, 9:19 p.m., Luigi Toscano wrote:
> > doc/fundamentals/index.docbook, line 39
> > <https://git.reviewboard.kde.org/r/129579/diff/1/?file=486795#file486795line39>
> >
> > I wonder if <releaseinfo> should be linked to the version of khelpcenter or something more general (like a revision number). This is really independent from Applications, it contains useful information for any Qt application which uses at least part of Frameworks.
>
> Burkhard Lück wrote:
> You are right, most of the info in fundamentals
> 1) depends on frameworks release, or
> 2) how Applications use frameworks (kmail switch to inline search + replace) or
> 3) generic info like the chapter installation (not release dependent).
>
> Because of 1)+2) what about <releaseinfo>Frameworks 5.28 / Applications 16.12</releaseinfo>?
Either that, or a custom release date (even date based, even 2016-11-30, or 1.0.1, or whatever).
> On Nov. 28, 2016, 9:19 p.m., Luigi Toscano wrote:
> > doc/fundamentals/tasks.docbook, line 929
> > <https://git.reviewboard.kde.org/r/129579/diff/1/?file=486797#file486797line929>
> >
> > look without .h:
> > https://lxr.kde.org/search?_filestring=&_string=kreplacedialog
> > it's also in ktexteditor, khtml, lokalize, okteta if I read the code correctly
>
> Burkhard Lück wrote:
> ktexteditor is no executable, find dialog looks different from th screenshot in khtml, lokalize, okteta
Right, there is a lack of homogeneity. The lokalize one seems to be the same (apart from few widgets); khtml is similar but not the same as kate/kwrite that you mentioned.
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129579/#review101168
-----------------------------------------------------------
On Nov. 28, 2016, 9:01 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129579/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 9:01 p.m.)
>
>
> Review request for Documentation.
>
>
> Repository: khelpcenter
>
>
> Description
> -------
>
> bump date + releaseinfo
> cleanup/update find + replace
> new screenshots
> add Help->Donate + Tip of the day
> explain how to use print to split a pdf
> more info about Show Menubar
>
>
> Diffs
> -----
>
> doc/fundamentals/find-find.png 59032f4
> doc/fundamentals/find-found.png fde3959
> doc/fundamentals/find-replace-inline.png 1b16e08
> doc/fundamentals/find-replace.png 85d657a
> doc/fundamentals/index.docbook 7782cad
> doc/fundamentals/install.docbook a47aac2
> doc/fundamentals/tasks.docbook 49ae3aa
> doc/fundamentals/ui.docbook bdc9621
>
> Diff: https://git.reviewboard.kde.org/r/129579/diff/
>
>
> Testing
> -------
>
> passes checkXML5
>
>
> File Attachments
> ----------------
>
> find-replace.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/28/c5493ec6-1546-48cb-862b-b50da9c95cfd__find-replace.png
> find-found.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/28/c1377b67-c8b1-4559-bdf7-79183bb60431__find-found.png
> find-replace-inline.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/28/c05e2f92-8c6f-4c6c-a99f-24a27fe0daf4__find-replace-inline.png
> find-find.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/28/8779eb23-9c3f-4300-bd81-b2814efbbba4__find-find.png
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20161130/5d8c2709/attachment.html>
More information about the kde-doc-english
mailing list