Review Request 129365: add encryption methods

Elvis Angelaccio elvis.angelaccio at kde.org
Mon Nov 14 18:25:45 UTC 2016



> On Nov. 11, 2016, 10:29 a.m., Elvis Angelaccio wrote:
> > doc/index.docbook, line 340
> > <https://git.reviewboard.kde.org/r/129365/diff/1/?file=484492#file484492line340>
> >
> >     Technically only zip and *only with the p7zip backend*, but I supposed this can be omitted since p7zip is supposed to be the default. Btw we should also add a warning messagewidget in the dialog, since a zip with AES256 encryption cannot be unpacked by infozip's unzip.
> >     
> >     Not sure if this should be in the docbook...
> 
> Burkhard Lück wrote:
>     > Technically only zip and only with the p7zip backend, but I supposed this can be omitted since p7zip is supposed to be the default. 
>     
>     Too technical for Joe User, and if p7zip is the default, we do not need to add this info here.
>     
>     > Btw we should also add a warning messagewidget in the dialog, since a zip with AES256 encryption cannot be unpacked by infozip's unzip.
>     
>     In recent ark master build from sources AES256 encryption as default for zip archives with password protection, 
>     but if a zip with this encryption cannot be unpacked by infozip's unzip, ark should offer another default encryption method for interoperability.
>     If the user selects an uncommon option here, he should get a warning about possible problems opening this archive in other programms than ark. 
>     > Not sure if this should be in the docbook...
>     
>     We should add a warning about encryption methods which cannot be processed by common archive programms.
>     AES128, AES192, AES256 and ZipCrypto are the available options, which are safe for interoperability, which are not?
> 
> Elvis Angelaccio wrote:
>     I think only ZipCrypto works everywhere. Yes, we need to warn the users about this (I'll come up with a patch if Ragnar doesn't beat me to it).
>     
>     About the screenshot, I'm also ok with keeping the single one

Patch with the warning up for review here: https://phabricator.kde.org/D3359


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129365/#review100773
-----------------------------------------------------------


On Nov. 9, 2016, 8:46 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129365/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 8:46 p.m.)
> 
> 
> Review request for Documentation, KDE Utils, Elvis Angelaccio, and Ragnar Thomsen.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> see summary
> update screenshot
> remove obsolete menuitem "Add Folder"
> 
> 
> Diffs
> -----
> 
>   doc/create-protected-archive.png abdec5d 
>   doc/index.docbook 0b9516e 
> 
> Diff: https://git.reviewboard.kde.org/r/129365/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> File Attachments
> ----------------
> 
> create-protected-archive.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/09/45cda3df-d54d-4f66-a470-378763393c80__create-protected-archive.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20161114/1c8d4800/attachment.html>


More information about the kde-doc-english mailing list