[kde-doc-english] Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Luigi Toscano]

> On Mag. 16, 2016, 11:41 a.m., Elvis Angelaccio wrote:
> > KF5DocToolsMacros.cmake, lines 47-49
> > <https://git.reviewboard.kde.org/r/127935/diff/1/?file=464948#file464948line47>
> >
> >     Maybe update this sentence as well? "... index.docbook is installed using KDOCTOOLS_CREATE_HANDBOOK."
> 
> Luigi Toscano wrote:
>     Makes sense.

Ups, ate my comment: I wanted to write that it is partially correct, as kdoctools_create_handbook installs all the other docbook files in that directory, but it is called only if index.docbook is available. Let me try with another fix to the documentation.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95503
-----------------------------------------------------------


On Mag. 16, 2016, 12:51 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> -----------------------------------------------------------
> 
> (Updated Mag. 16, 2016, 12:51 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
>     https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> When more documentation files are available in a certain directory, the assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in the same directory.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake a0ed3a8 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> -------
> 
> Tried kdoctools_install when the (translated) documentation is made of multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20160516/f635a540/attachment.html>