[kde-doc-english] Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95503
-----------------------------------------------------------




KF5DocToolsMacros.cmake (lines 47 - 49)
<https://git.reviewboard.kde.org/r/127935/#comment64733>

    Maybe update this sentence as well? "... index.docbook is installed using KDOCTOOLS_CREATE_HANDBOOK."


- Elvis Angelaccio


On May 15, 2016, 10:51 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 10:51 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
>     https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> When more documentation files are available in a certain directory, the assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in the same directory.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake a0ed3a8 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> -------
> 
> Tried kdoctools_install when the (translated) documentation is made of multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20160516/f0205578/attachment.html>